From: Avan Thakkar <athakkar@redhat.com>
Date: Mon, 16 Jan 2023 12:41:06 +0000 (+0530)
Subject: mgr/prometheus: export zero valued pg state metrics
X-Git-Tag: v18.1.0~502^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=17d1ecc914b2fe6c5d9e8045a999985988c39447;p=ceph-ci.git

mgr/prometheus: export zero valued pg state metrics

Fixes: https://tracker.ceph.com/issues/58471
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

As per the Prometheus documentation, omitting zero metrics is not a best practice. The metric value for all PG_STATES should be initialized to zero.
---

diff --git a/src/pybind/mgr/prometheus/module.py b/src/pybind/mgr/prometheus/module.py
index ab083d87d10..069330c392c 100644
--- a/src/pybind/mgr/prometheus/module.py
+++ b/src/pybind/mgr/prometheus/module.py
@@ -1065,6 +1065,8 @@ class Module(MgrModule):
 
         for pool in pg_summary['by_pool']:
             num_by_state: DefaultDict[str, int] = defaultdict(int)
+            for state in PG_STATES:
+                num_by_state[state] = 0
 
             for state_name, count in pg_summary['by_pool'][pool].items():
                 for state in state_name.split('+'):