From: Rishabh Dave <ridave@redhat.com>
Date: Wed, 8 Jun 2022 17:04:51 +0000 (+0530)
Subject: qa/cephfs: modify user creation code for xfstests-dev
X-Git-Tag: v18.1.0~303^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=18465b8f56dd10ff42fa9cc66988f1da714698b8;p=ceph.git

qa/cephfs: modify user creation code for xfstests-dev

Create user "fsgqa2" and, since xfstests-dev's README uses option "-m"
while creating user "fsgqa", do the same in our codebase.

Creating user "fsgqa2" is optional along with other users according to
xfstests-dev's README. Create all these users is a preventive step since
tests needing user/users maybe skipped during execution.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
---

diff --git a/qa/tasks/cephfs/xfstests_dev.py b/qa/tasks/cephfs/xfstests_dev.py
index c507dbe4963f..005d6bf407ec 100644
--- a/qa/tasks/cephfs/xfstests_dev.py
+++ b/qa/tasks/cephfs/xfstests_dev.py
@@ -185,10 +185,12 @@ class XFSTestsDev(CephFSTestCase):
         self.mount_a.client_remote.run(args=args, omit_sudo=False)
 
     def create_reqd_users(self):
-        self.mount_a.client_remote.run(args=['sudo', 'useradd', 'fsgqa'],
+        self.mount_a.client_remote.run(args=['sudo', 'useradd', '-m', 'fsgqa'],
                                        omit_sudo=False, check_status=False)
         self.mount_a.client_remote.run(args=['sudo', 'groupadd', 'fsgqa'],
                                        omit_sudo=False, check_status=False)
+        self.mount_a.client_remote.run(args=['sudo', 'useradd', 'fsgqa2'],
+                                       omit_sudo=False, check_status=False)
         self.mount_a.client_remote.run(args=['sudo', 'useradd',
                                              '123456-fsgqa'], omit_sudo=False,
                                        check_status=False)