From: David Zafman <dzafman@redhat.com>
Date: Wed, 24 Jul 2019 21:19:43 +0000 (-0700)
Subject: osd: Add debug_heartbeat_testing_span to allow quicker testing
X-Git-Tag: v13.2.7~26^2~9
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=1a10ca723e113bbe0609365d18297e53dba55657;p=ceph.git

osd: Add debug_heartbeat_testing_span to allow quicker testing

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 573aea2bb1d48237df5182a6e4421e15c1eea88c)
---

diff --git a/src/common/options.cc b/src/common/options.cc
index 3a35947e52d9..315f47d86176 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -5008,6 +5008,10 @@ std::vector<Option> get_global_options() {
     Option("debug_disable_randomized_ping", Option::TYPE_BOOL, Option::LEVEL_DEV)
     .set_default(false)
     .set_description("Disable heartbeat ping randomization for testing purposes"),
+
+    Option("debug_heartbeat_testing_span", Option::TYPE_INT, Option::LEVEL_DEV)
+    .set_default(0)
+    .set_description("Override 60 second periods for testing only"),
   });
 }
 
diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index f6edeb39185a..321de0189c60 100644
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -4813,7 +4813,11 @@ void OSD::handle_osd_ping(MOSDPing *m)
 	    ceph_assert(i->second.hb_interval_start != utime_t());
 	    if (i->second.hb_interval_start == utime_t())
 	      i->second.hb_interval_start = now;
-	    if (now - i->second.hb_interval_start >=  utime_t(hb_avg, 0)) {
+	    int64_t hb_avg_time_period = 60;
+	    if (cct->_conf.get_val<int64_t>("debug_heartbeat_testing_span")) {
+	      hb_avg_time_period = cct->_conf.get_val<int64_t>("debug_heartbeat_testing_span");
+	    }
+	    if (now - i->second.hb_interval_start >=  utime_t(hb_avg_time_period, 0)) {
               uint32_t back_avg = i->second.hb_total_back / i->second.hb_average_count;
               uint32_t back_min = i->second.hb_min_back;
               uint32_t back_max = i->second.hb_max_back;
diff --git a/src/osd/OSD.h b/src/osd/OSD.h
index 900c9cdd0efe..81eabebc74d6 100644
--- a/src/osd/OSD.h
+++ b/src/osd/OSD.h
@@ -1581,7 +1581,6 @@ private:
   utime_t last_heartbeat_resample;   ///< last time we chose random peers in waiting-for-healthy state
   double daily_loadavg;
 
-  const uint32_t hb_avg = 60;
   // Track ping repsonse times using vector as a circular buffer
   // MUST BE A POWER OF 2
   const uint32_t hb_vector_size = 16;