From: Kefu Chai <kchai@redhat.com>
Date: Thu, 3 Jun 2021 05:45:05 +0000 (+0800)
Subject: crimson/admin: s/perf dump_seastar/dump_metrics/
X-Git-Tag: v17.1.0~1770^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=1a48978794ea0f68fd4b04960682e9aff28c9dcf;p=ceph.git

crimson/admin: s/perf dump_seastar/dump_metrics/

as a user-facing interface, no need to expose seastar in the name,
what matters to user is the content not the underlying technology or library.

so rename the command prefix to "dump_metrics"

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/crimson/admin/osd_admin.cc b/src/crimson/admin/osd_admin.cc
index cea9bdb959be..16df274b3253 100644
--- a/src/crimson/admin/osd_admin.cc
+++ b/src/crimson/admin/osd_admin.cc
@@ -200,7 +200,7 @@ template std::unique_ptr<AdminSocketHook> make_asok_hook<AssertAlwaysHook>();
 class DumpMetricsHook : public AdminSocketHook {
 public:
   DumpMetricsHook() :
-    AdminSocketHook("perf dump_seastar",
+    AdminSocketHook("dump_metrics",
                     "name=group,type=CephString,req=false",
                     "dump current configured seastar metrics and their values")
   {}
@@ -211,7 +211,7 @@ public:
     std::unique_ptr<Formatter> f{Formatter::create(format, "json-pretty", "json-pretty")};
     std::string prefix;
     cmd_getval(cmdmap, "group", prefix);
-    f->open_object_section("perf_dump_seastar");
+    f->open_object_section("metrics");
     for (const auto& [full_name, metric_family]: seastar::scollectd::get_value_map()) {
       if (!prefix.empty() && full_name.compare(0, prefix.size(), prefix) != 0) {
        continue;