From: Greg Farnum <gregf@hq.newdream.net>
Date: Fri, 5 Mar 2010 01:16:48 +0000 (-0800)
Subject: mon: fix bad return test!
X-Git-Tag: v0.20~330
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=1b211e5ef3f6ba9ed39a1cdf68adce4610b013f7;p=ceph.git

mon: fix bad return test!

cephx_build_service_ticket_blob returns a bool, so it's not ever
going to return <0 -- or if it somehow does that'll be true (good, not false!
---

diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index 79009a591e4e..e20048749e4d 100644
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -997,8 +997,7 @@ bool Monitor::ms_get_authorizer(int dest_type, AuthAuthorizer **authorizer, bool
   }
 
   CephXTicketBlob blob;
-  ret = cephx_build_service_ticket_blob(info, blob);
-  if (ret < 0)
+  if (!cephx_build_service_ticket_blob(info, blob))
     return false;
   bufferlist ticket_data;
   ::encode(blob, ticket_data);