From: Yan, Zheng <zyan@redhat.com>
Date: Mon, 15 Dec 2014 01:50:23 +0000 (+0800)
Subject: mds: fix MDCache::journal_cow_dentry()
X-Git-Tag: v0.93~87^2~32
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=1d9de22606087267a228ac9d69366a01dfe5982c;p=ceph.git

mds: fix MDCache::journal_cow_dentry()

Use parent directory's snaprealm to decide if we should cow dentry.
Otherwise we may create orphan dentry when deleting an directory with
snaprealm.

Signed-off-by: Yan, Zheng <zyan@redhat.com>
---

diff --git a/src/mds/MDCache.cc b/src/mds/MDCache.cc
index 7926da79b8a2..cdf59a6a8bbc 100644
--- a/src/mds/MDCache.cc
+++ b/src/mds/MDCache.cc
@@ -1567,21 +1567,31 @@ void MDCache::journal_cow_dentry(MutationImpl *mut, EMetaBlob *metablob,
     // multiversion inode.
     CInode *in = dnl->get_inode();
 
-    if (follows == CEPH_NOSNAP)
+    if (in->get_projected_parent_dn() != dn) {
+      assert(follows == CEPH_NOSNAP);
+      snapid_t dir_follows = dn->dir->inode->find_snaprealm()->get_newest_seq();
+
+      if (dir_follows+1 > dn->first) {
+	snapid_t oldfirst = dn->first;
+	dn->first = dir_follows+1;
+	CDentry *olddn = dn->dir->add_remote_dentry(dn->name, in->ino(),  in->d_type(),
+						    oldfirst, dir_follows);
+	olddn->pre_dirty();
+	dout(10) << " olddn " << *olddn << dendl;
+	metablob->add_remote_dentry(olddn, true);
+	mut->add_cow_dentry(olddn);
+	// FIXME: adjust link count here?  hmm.
+
+	if (dir_follows+1 > in->first)
+	  in->cow_old_inode(dir_follows, false);
+      }
+
+      if (in->snaprealm)
+	follows = in->snaprealm->get_newest_seq();
+      else
+	follows = dir_follows;
+    } else if (follows == CEPH_NOSNAP) {
       follows = in->find_snaprealm()->get_newest_seq();
-
-    if (in->get_projected_parent_dn() != dn &&
-	follows+1 > dn->first) {
-      snapid_t oldfirst = dn->first;
-      dn->first = follows+1;
-      CDentry *olddn = dn->dir->add_remote_dentry(dn->name, in->ino(),  in->d_type(),
-						  oldfirst, follows);
-      olddn->pre_dirty();
-      dout(10) << " olddn " << *olddn << dendl;
-      metablob->add_remote_dentry(olddn, true);
-      mut->add_cow_dentry(olddn);
-
-      // FIXME: adjust link count here?  hmm.
     }
 
     // already cloned?