From: Somnath Roy <somnath.roy@sandisk.com>
Date: Tue, 9 Sep 2014 01:59:01 +0000 (-0700)
Subject: OpTracker: Removed _dump_op_descriptor_unlocked call for log level < 5
X-Git-Tag: v0.86~43^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=1de43e00639b5e53ac2bf19e6625350209fca2b0;p=ceph.git

OpTracker: Removed _dump_op_descriptor_unlocked call for log level < 5

_dump_op_descriptor_unlocked call within the function _mark_event()
was invoked unnecessarily every time for all log levels. This was
degrading performance significantly! The stream is only used during
log level 5 and thus the _dump_op_descriptor_unlocked() is only called
now if user sets the log level to 5 and beyond.

Signed-off-by: Somnath Roy <somnath.roy@sandisk.com>
---

diff --git a/src/common/TrackedOp.cc b/src/common/TrackedOp.cc
index 8590c588f2de..d7a95b87ac1f 100644
--- a/src/common/TrackedOp.cc
+++ b/src/common/TrackedOp.cc
@@ -283,12 +283,13 @@ void OpTracker::mark_event(TrackedOp *op, const string &dest, utime_t time)
 void OpTracker::_mark_event(TrackedOp *op, const string &evt,
 			    utime_t time)
 {
-  stringstream ss;
-  op->_dump_op_descriptor_unlocked(ss);
-  dout(5) << //"reqid: " << op->get_reqid() <<
-	     ", seq: " << op->seq
+  dout(5);
+  *_dout  <<  "seq: " << op->seq
 	  << ", time: " << time << ", event: " << evt
-	  << ", op: " << ss.str() << dendl;
+	  << ", op: ";
+  op->_dump_op_descriptor_unlocked(*_dout);
+  *_dout << dendl;
+     
 }
 
 void OpTracker::RemoveOnDelete::operator()(TrackedOp *op) {