From: Greg Farnum <greg@inktank.com>
Date: Fri, 12 Jul 2013 23:38:39 +0000 (-0700)
Subject: test_rgw: fix a number of unsigned/signed comparison warnings
X-Git-Tag: v0.67-rc1~71^2~5^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=1dfd06dfada3e6740fbefbad3a094853bdd679e8;p=ceph.git

test_rgw: fix a number of unsigned/signed comparison warnings

Signed-off-by: Greg Farnum <greg@inktank.com>
---

diff --git a/src/test/test_rgw_admin_log.cc b/src/test/test_rgw_admin_log.cc
index 876c76973e05..df52ce551171 100644
--- a/src/test/test_rgw_admin_log.cc
+++ b/src/test/test_rgw_admin_log.cc
@@ -124,10 +124,12 @@ class test_helper {
 
 int test_helper::extract_input(int argc, char *argv[]){
 #define ERR_CHECK_NEXT_PARAM(o) \
-  if((loop + 1) >= argc)return -1; \
+  if((loop + 1) >= argcount)return -1; \
   else o = argv[loop+1];
 
-  for(unsigned loop = 1;loop < (unsigned)argc; loop += 2){
+  unsigned argcount = argc;
+
+  for(unsigned loop = 1;loop < argcount; loop += 2){
     if(strcmp(argv[loop], "-g") == 0){
       ERR_CHECK_NEXT_PARAM(host);
     }else if(strcmp(argv[loop],"-p") == 0){
diff --git a/src/test/test_rgw_admin_meta.cc b/src/test/test_rgw_admin_meta.cc
index f366c83c7824..ccba4e5ea9b4 100644
--- a/src/test/test_rgw_admin_meta.cc
+++ b/src/test/test_rgw_admin_meta.cc
@@ -118,10 +118,12 @@ class test_helper {
 
 int test_helper::extract_input(int argc, char *argv[]){
 #define ERR_CHECK_NEXT_PARAM(o) \
-  if((loop + 1) >= argc)return -1; \
+  if((loop + 1) >= argcount)return -1; \
   else o = argv[loop+1];
 
-  for(unsigned loop = 1;loop < (unsigned)argc; loop += 2){
+  unsigned argcount = argc;
+
+  for(unsigned loop = 1;loop < argcount; loop += 2){
     if(strcmp(argv[loop], "-g") == 0){
       ERR_CHECK_NEXT_PARAM(host);
     }else if(strcmp(argv[loop],"-p") == 0){
diff --git a/src/test/test_rgw_admin_opstate.cc b/src/test/test_rgw_admin_opstate.cc
index cfd709043dd6..ed0c5472f2ad 100644
--- a/src/test/test_rgw_admin_opstate.cc
+++ b/src/test/test_rgw_admin_opstate.cc
@@ -121,10 +121,12 @@ class test_helper {
 
 int test_helper::extract_input(int argc, char *argv[]){
 #define ERR_CHECK_NEXT_PARAM(o) \
-  if((loop + 1) >= argc)return -1; \
+  if((loop + 1) >= argcount)return -1; \
   else o = argv[loop+1];
 
-  for(unsigned loop = 1;loop < (unsigned)argc; loop += 2){
+  unsigned argcount = argc;
+
+  for(unsigned loop = 1; loop < argcount; loop += 2){
     if(strcmp(argv[loop], "-g") == 0){
       ERR_CHECK_NEXT_PARAM(host);
     }else if(strcmp(argv[loop],"-p") == 0){
@@ -575,7 +577,7 @@ TEST(TestRGWAdmin, opstate_set_list_delete) {
     EXPECT_TRUE((*it).client_id.compare(cid_1) == 0);
     EXPECT_TRUE((*it).op_id.compare(oid_1) == 0);
     EXPECT_TRUE((*it).object.compare(obj_1) == 0);
-    EXPECT_EQ((*it).state, RGWOpState::OPSTATE_IN_PROGRESS);
+    EXPECT_EQ((*it).state, (uint32_t)RGWOpState::OPSTATE_IN_PROGRESS);
   }
 
   state = "complete";
@@ -600,7 +602,7 @@ TEST(TestRGWAdmin, opstate_set_list_delete) {
     EXPECT_TRUE((*it).client_id.compare(cid_1) == 0);
     EXPECT_TRUE((*it).op_id.compare(oid_1) == 0);
     EXPECT_TRUE((*it).object.compare(obj_1) == 0);
-    EXPECT_EQ((*it).state, RGWOpState::OPSTATE_COMPLETE);
+    EXPECT_EQ((*it).state, (uint32_t)RGWOpState::OPSTATE_COMPLETE);
   }
 
   ss.str("");
@@ -624,13 +626,13 @@ TEST(TestRGWAdmin, opstate_set_list_delete) {
     EXPECT_TRUE((*it).client_id.compare(cid_1) == 0);
     EXPECT_TRUE((*it).op_id.compare(oid_1) == 0);
     EXPECT_TRUE((*it).object.compare(obj_1) == 0);
-    EXPECT_EQ((*it).state, RGWOpState::OPSTATE_COMPLETE);
+    EXPECT_EQ((*it).state, (uint32_t)RGWOpState::OPSTATE_COMPLETE);
 
     it++;
     EXPECT_TRUE((*it).client_id.compare(cid_2) == 0);
     EXPECT_TRUE((*it).op_id.compare(oid_2) == 0);
     EXPECT_TRUE((*it).object.compare(obj_2) == 0);
-    EXPECT_EQ((*it).state, RGWOpState::OPSTATE_COMPLETE);
+    EXPECT_EQ((*it).state, (uint32_t)RGWOpState::OPSTATE_COMPLETE);
   }
 
   entries.clear();