From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Tue, 30 May 2017 08:56:23 +0000 (+0200)
Subject: test_ipaddr.cc: memset with 0 and not '0'
X-Git-Tag: v13.0.1~1052^2~4
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=1ec2de3003c4e1b3cd9603d65cb8fdd5bad4174c;p=ceph.git

test_ipaddr.cc: memset with 0 and not '0'

Fix for:

CID 1405070 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405071 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405073 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405074 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405075 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405077 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405083 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405086 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405087 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
 bad_memset: "memset" with fill value "'0'" (the zero character).
 memset(&net, 48, 28UL). (CWE-665)

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/test/test_ipaddr.cc b/src/test/test_ipaddr.cc
index 6f5a42f8fabc..3910660b77d3 100644
--- a/src/test/test_ipaddr.cc
+++ b/src/test/test_ipaddr.cc
@@ -36,7 +36,7 @@ TEST(CommonIPAddr, TestNotFound)
   struct sockaddr_in net;
   const struct ifaddrs *result;
 
-  memset(&net, '0', sizeof(net));
+  memset(&net, 0, sizeof(net));
 
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
@@ -62,7 +62,7 @@ TEST(CommonIPAddr, TestV4_Simple)
   struct sockaddr_in net;
   const struct ifaddrs *result;
 
-  memset(&net, '0', sizeof(net));
+  memset(&net, 0, sizeof(net));
 
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
@@ -88,7 +88,7 @@ TEST(CommonIPAddr, TestV4_Prefix25)
   struct sockaddr_in net;
   const struct ifaddrs *result;
 
-  memset(&net, '0', sizeof(net));
+  memset(&net, 0, sizeof(net));
 
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
@@ -114,7 +114,7 @@ TEST(CommonIPAddr, TestV4_Prefix16)
   struct sockaddr_in net;
   const struct ifaddrs *result;
 
-  memset(&net, '0', sizeof(net));
+  memset(&net, 0, sizeof(net));
 
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
@@ -139,7 +139,7 @@ TEST(CommonIPAddr, TestV4_PrefixTooLong)
   struct sockaddr_in net;
   const struct ifaddrs *result;
 
-  memset(&net, '0', sizeof(net));
+  memset(&net, 0, sizeof(net));
 
   one.ifa_next = NULL;
   one.ifa_addr = (struct sockaddr*)&a_one;
@@ -160,7 +160,7 @@ TEST(CommonIPAddr, TestV4_PrefixZero)
   struct sockaddr_in net;
   const struct ifaddrs *result;
 
-  memset(&net, '0', sizeof(net));
+  memset(&net, 0, sizeof(net));
 
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
@@ -186,8 +186,8 @@ TEST(CommonIPAddr, TestV6_Simple)
   struct sockaddr_in6 net;
   const struct ifaddrs *result;
 
-  memset(&net, '0', sizeof(net));
-  
+  memset(&net, 0, sizeof(net));
+
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
   one.ifa_name = eth0;
@@ -212,7 +212,7 @@ TEST(CommonIPAddr, TestV6_Prefix57)
   struct sockaddr_in6 net;
   const struct ifaddrs *result;
 
-  memset(&net, '0', sizeof(net));
+  memset(&net, 0, sizeof(net));
 
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
@@ -237,7 +237,7 @@ TEST(CommonIPAddr, TestV6_PrefixTooLong)
   struct sockaddr_in6 net;
   const struct ifaddrs *result;
 
-  memset(&net, '0', sizeof(net));
+  memset(&net, 0, sizeof(net));
 
   one.ifa_next = NULL;
   one.ifa_addr = (struct sockaddr*)&a_one;