From: Alfredo Deza <alfredo.deza@inktank.com>
Date: Tue, 20 Aug 2013 14:14:51 +0000 (-0400)
Subject: use the return code to determine if lsb_release is present
X-Git-Tag: v1.2.2~4^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=1efa2374fec4f6ee3c3f67b41b2e45a8b8894f8e;p=ceph-deploy.git

use the return code to determine if lsb_release is present

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
---

diff --git a/ceph_deploy/hosts/__init__.py b/ceph_deploy/hosts/__init__.py
index 96a976e..fb14b77 100644
--- a/ceph_deploy/hosts/__init__.py
+++ b/ceph_deploy/hosts/__init__.py
@@ -67,8 +67,8 @@ def lsb_fallback(conn):
 
 
 def has_lsb(conn):
-    stdout, stderr, _ = wrappers.Popen(conn, logger, ['which', 'lsb_release'])
-    return stderr == ''
+    _, _, ret_code = wrappers.Popen(conn, logger, ['which', 'lsb_release'])
+    return ret_code == 0
 
 
 def _get_distro(distro, fallback=None):