From: Anand Jain Date: Sun, 29 Jan 2023 02:42:33 +0000 (+0800) Subject: fstests: aiodio_sparse2.c, fix compiler warning buffer overflow X-Git-Tag: v2023.02.05~1 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=1f12612b7c294af83b201f9c9056f8d4de0acb30;p=xfstests-dev.git fstests: aiodio_sparse2.c, fix compiler warning buffer overflow The warning is due to 'strncpy' with a maximum number of characters equal to the destination buffer size, without space for null termination. aiodio_sparse2.c: In function 'main': aiodio_sparse2.c:404:9: warning: 'strncpy' specified bound 4096 equals destination size [-Wstringop-truncation] 404 | strncpy(filename, argv[argc-1], PATH_MAX); However, PATH_MAX is including null termination at the end. Anyways, fix warning by setting NULL. Signed-off-by: Anand Jain Reviewed-by: Bill O'Donnell Signed-off-by: Zorro Lang --- diff --git a/src/aio-dio-regress/aiodio_sparse2.c b/src/aio-dio-regress/aiodio_sparse2.c index 51ede5bb..685e3b9d 100644 --- a/src/aio-dio-regress/aiodio_sparse2.c +++ b/src/aio-dio-regress/aiodio_sparse2.c @@ -402,6 +402,7 @@ int main(int argc, char **argv) } strncpy(filename, argv[argc-1], PATH_MAX); + filename[PATH_MAX - 1] = '\0'; if (alignment == 0) alignment = get_logical_block_size(filename);