From: Radoslaw Zarzynski <rzarzyns@redhat.com>
Date: Mon, 25 Nov 2024 18:59:12 +0000 (+0000)
Subject: osd: drop dead code that depends on OmapIterator::status()
X-Git-Tag: testing/wip-vshankar-testing-20250411.090237-debug~43^2~21
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=201b51d7200756572224d72f88033b98739b5a63;p=ceph-ci.git

osd: drop dead code that depends on OmapIterator::status()

For `BlueStore`, `MemStore` and `KStore` the `status()`
unconditionally returns `0`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
---

diff --git a/src/osd/ReplicatedBackend.cc b/src/osd/ReplicatedBackend.cc
index a2129f237e3..9ee549eb165 100644
--- a/src/osd/ReplicatedBackend.cc
+++ b/src/osd/ReplicatedBackend.cc
@@ -813,7 +813,7 @@ int ReplicatedBackend::be_deep_scrub(
     iter->seek_to_first();
   }
   int max = g_conf()->osd_deep_scrub_keys;
-  while (iter->status() == 0 && iter->valid()) {
+  while (iter->valid()) {
     pos.omap_bytes += iter->value().length();
     ++pos.omap_keys;
     --max;
@@ -829,12 +829,6 @@ int ReplicatedBackend::be_deep_scrub(
       pos.omap_pos = iter->key();
       return -EINPROGRESS;
     }
-    if (iter->status() < 0) {
-      dout(25) << __func__ << "  " << poid
-	       << " on omap scan, db status error" << dendl;
-      o.read_error = true;
-      return 0;
-    }
   }
 
   if (pos.omap_keys > cct->_conf->