From: Matan Breizman <mbreizma@redhat.com>
Date: Wed, 3 Sep 2025 11:25:28 +0000 (+0000)
Subject: crimson/os/seastore: Remove error on expected logic
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2092ad0c2d80e8266dc5a635d428df13d5196535;p=ceph.git

crimson/os/seastore: Remove error on expected logic

In read_meta we should not use ERROR when the key is not found
as this is expected.
Same in _mkfs, if mkfs_done exists we shouldn't use ERROR.
This can be confusing when debugging is disabled and few ERROR log
lines are printed.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
---

diff --git a/src/crimson/os/seastore/device.cc b/src/crimson/os/seastore/device.cc
index 8940afb3590a..1923f32f11eb 100644
--- a/src/crimson/os/seastore/device.cc
+++ b/src/crimson/os/seastore/device.cc
@@ -83,7 +83,7 @@ check_create_device_ret check_create_device(
 	return seastar::now();
       } catch (const std::system_error &e) {
 	if (e.code().value() == EEXIST) {
-          ERROR("path={} exists", path);
+          DEBUG("path={} exists", path);
 	  return seastar::now();
 	} else {
           ERROR("path={} creation error -- {}", path, e);
diff --git a/src/crimson/os/seastore/seastore.cc b/src/crimson/os/seastore/seastore.cc
index 684a54dbce14..3b99d6fa1443 100644
--- a/src/crimson/os/seastore/seastore.cc
+++ b/src/crimson/os/seastore/seastore.cc
@@ -438,9 +438,10 @@ Device::access_ertr::future<> SeaStore::_mkfs(uuid_d new_osd_fsid)
   // todo: read_meta to return errorator
   auto [done, value] = co_await read_meta("mkfs_done");
   if (done == 0) {
-    ERROR("failed");
+    DEBUG("mkfs_done exists, Skipping mkfs");
     co_return;
   }
+  DEBUG("mkfs_done does not exist, starting mkfs");
   secondary_device_set_t sds;
   if (!root.empty()) {
     seastar::file rdir = co_await seastar::open_directory(root);
@@ -2323,7 +2324,7 @@ SeaStore::read_meta(const std::string& key)
       DEBUG("key={}, value={}", key, *v);
       return std::make_tuple(0, std::move(*v));
     } else {
-      ERROR("key={} failed", key);
+      DEBUG("key={} coudln't find key:", key);
       return std::make_tuple(-1, std::string(""));
     }
   }).handle_error(