From: Sebastian Wagner Date: Tue, 23 Feb 2021 10:01:52 +0000 (+0100) Subject: mgr/rook: OSD create: Fix broken list-comprehension X-Git-Tag: v17.1.0~1655^2~4 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=20e02db29e433b5c163244ac5c8a03d243ec9c08;p=ceph.git mgr/rook: OSD create: Fix broken list-comprehension Signed-off-by: Sebastian Wagner --- diff --git a/src/pybind/mgr/rook/rook_cluster.py b/src/pybind/mgr/rook/rook_cluster.py index 4fd660430364..daf3c8667b71 100644 --- a/src/pybind/mgr/rook/rook_cluster.py +++ b/src/pybind/mgr/rook/rook_cluster.py @@ -592,7 +592,8 @@ class RookCluster(object): if block_devices: if not hasattr(current_node, 'devices'): current_node.devices = ccl.DevicesList() - new_devices = list(set(block_devices) - set([d.name for d in current_node.devices])) + current_device_names = set(d.name for d in current_node.devices) + new_devices = [bd for bd in block_devices if bd.path not in current_device_names] current_node.devices.extend( ccl.DevicesItem(name=n.path) for n in new_devices )