From: David Disseldorp Date: Mon, 12 Dec 2022 23:08:20 +0000 (+0100) Subject: check: ensure sect_stop is initialized if interrupted X-Git-Tag: v2022.12.18~7 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=210af953f70974ec794b40f7f8769c5637df77da;p=xfstests-dev.git check: ensure sect_stop is initialized if interrupted sect_stop is normally set immediately prior to calling _wrapup() via run_section(). However, when called via a trap signal handler, sect_stop may be uninitialized, leading to a negative section time (sect_stop - sect_start) in the xunit report. E.g. Interrupted! Passed all 1 tests Xunit report: /home/david/xfstests/results//result.xml rapido1:/# head /home/david/xfstests/results//result.xml This commit uses the existing $interrupt flag to determine when sect_stop needs to be initialised. Signed-off-by: David Disseldorp Reviewed-by: Zorro Lang Signed-off-by: Zorro Lang --- diff --git a/check b/check index f7f93dc4..1022e853 100755 --- a/check +++ b/check @@ -433,6 +433,7 @@ _wrapup() { seq="check" check="$RESULT_BASE/check" + $interrupt && sect_stop=`_wallclock` if $showme && $needwrap; then if $do_report; then