From: Samuel Just Date: Thu, 26 Sep 2019 22:04:09 +0000 (-0700) Subject: osd/: remove legacy schedulers X-Git-Tag: v15.1.0~1180^2~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2157ac7d14c386b3472e47d2f227c97c9d69e60c;p=ceph.git osd/: remove legacy schedulers The consensus seems to be that PrioritizedQueue is strictly worse than WeightedPriorityQueue. mClockClientQueue and mClockClassQueue are superceded by mClockScheduler. Signed-off-by: Samuel Just --- diff --git a/qa/tasks/mgr/dashboard/test_cluster_configuration.py b/qa/tasks/mgr/dashboard/test_cluster_configuration.py index 798afe9c19c1..a4410d4fadf9 100644 --- a/qa/tasks/mgr/dashboard/test_cluster_configuration.py +++ b/qa/tasks/mgr/dashboard/test_cluster_configuration.py @@ -314,9 +314,6 @@ class ClusterConfigurationTest(DashboardTestCase): 'osd_deep_scrub_randomize_ratio', # osd-pg-scrub 'osd_deep_scrub_stride', # osd-pg-scrub 'osd_deep_scrub_update_digest_min_age', # osd-pg-scrub - 'osd_op_queue_mclock_scrub_lim', # osd-pg-scrub - 'osd_op_queue_mclock_scrub_res', # osd-pg-scrub - 'osd_op_queue_mclock_scrub_wgt', # osd-pg-scrub 'osd_requested_scrub_priority', # osd-pg-scrub 'osd_scrub_backoff_ratio', # osd-pg-scrub 'osd_scrub_chunk_max', # osd-pg-scrub diff --git a/src/common/legacy_config_opts.h b/src/common/legacy_config_opts.h index 35d4895c3b52..cc53ef164582 100644 --- a/src/common/legacy_config_opts.h +++ b/src/common/legacy_config_opts.h @@ -621,30 +621,6 @@ OPTION(osd_op_queue, OPT_STR) OPTION(osd_op_queue_cut_off, OPT_STR) // Min priority to go to strict queue. (low, high) -// mClock priority queue parameters for five types of ops -OPTION(osd_op_queue_mclock_client_op_res, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_client_op_wgt, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_client_op_lim, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_osd_rep_op_res, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_osd_rep_op_wgt, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_osd_rep_op_lim, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_snap_res, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_snap_wgt, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_snap_lim, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_recov_res, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_recov_wgt, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_recov_lim, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_scrub_res, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_scrub_wgt, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_scrub_lim, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_pg_delete_res, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_pg_delete_wgt, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_pg_delete_lim, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_peering_event_res, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_peering_event_wgt, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_peering_event_lim, OPT_DOUBLE) -OPTION(osd_op_queue_mclock_anticipation_timeout, OPT_DOUBLE) - OPTION(osd_ignore_stale_divergent_priors, OPT_BOOL) // do not assert on divergent_prior entries which aren't in the log and whose on-disk objects are newer // Set to true for testing. Users should NOT set this. diff --git a/src/common/options.cc b/src/common/options.cc index 6c1e7b772001..67cd93b89a3e 100644 --- a/src/common/options.cc +++ b/src/common/options.cc @@ -2872,461 +2872,10 @@ std::vector