From: Matan Breizman <mbreizma@redhat.com>
Date: Thu, 3 Apr 2025 12:36:22 +0000 (+0300)
Subject: ceph-dev*: final transition to WITH_CRIMSON
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=21a5a392c92841b6dcd03475ca624f0f2e47faeb;p=ceph-build.git

ceph-dev*: final transition to WITH_CRIMSON

Follow up to: https://github.com/ceph/ceph-build/pull/2329
Now that https://github.com/ceph/ceph/pull/62325 is merged.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
---

diff --git a/ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml b/ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml
index 8e5dd2fb..d930bdff 100644
--- a/ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml
+++ b/ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml
@@ -69,7 +69,7 @@
               export WITH_SEASTAR=true
               # TODO use clang-10 on ubuntu/focal
               timeout 7200 src/script/run-make.sh \
-                --cmake-args "-DCMAKE_CXX_COMPILER=$cxx_compiler -DCMAKE_C_COMPILER=$c_compiler -DCMAKE_BUILD_TYPE=Release -DWITH_SEASTAR=ON -DWITH_CRIMSON=ON -DWITH_TESTS=OFF" \
+                --cmake-args "-DCMAKE_CXX_COMPILER=$cxx_compiler -DCMAKE_C_COMPILER=$c_compiler -DCMAKE_BUILD_TYPE=Release -DWITH_CRIMSON=ON -DWITH_TESTS=OFF" \
                 vstart-base crimson-osd
               src/script/run-cbt.sh --build-dir $PWD/build --source-dir $PWD --cbt ${{WORKSPACE}}/cbt -a $archive_dir src/test/crimson/cbt/radosbench_4K_read.yaml
           else
diff --git a/ceph-pull-requests-arm64/build/build b/ceph-pull-requests-arm64/build/build
index 3345203c..8b4c1372 100644
--- a/ceph-pull-requests-arm64/build/build
+++ b/ceph-pull-requests-arm64/build/build
@@ -11,7 +11,6 @@ n_build_jobs=$(get_nr_build_jobs)
 n_test_jobs=${n_build_jobs}
 export CHECK_MAKEOPTS="-j${n_test_jobs}"
 export BUILD_MAKEOPTS="-j${n_build_jobs}"
-export WITH_SEASTAR=true
 export WITH_CRIMSON=true
 export WITH_RBD_RWL=true
 timeout 4h ./run-make-check.sh
diff --git a/ceph-pull-requests/build/build b/ceph-pull-requests/build/build
index c3a172ec..351b2b7f 100644
--- a/ceph-pull-requests/build/build
+++ b/ceph-pull-requests/build/build
@@ -8,7 +8,6 @@ if [[ "$DOCS_ONLY" = true || "$CONTAINER_ONLY" = true ]]; then
 fi
 
 export NPROC=$(nproc)
-export WITH_SEASTAR=true
 export WITH_CRIMSON=true
 export WITH_RBD_RWL=true
 timeout 3h ./run-make-check.sh
diff --git a/scripts/build_utils.sh b/scripts/build_utils.sh
index ba6756ad..6b86f4ab 100755
--- a/scripts/build_utils.sh
+++ b/scripts/build_utils.sh
@@ -876,8 +876,7 @@ ceph_build_args_from_flavor() {
         DEB_BUILD_PROFILES=""
         ;;
     crimson)
-        CEPH_EXTRA_RPMBUILD_ARGS="--with seastar"
-        CEPH_EXTRA_RPMBUILD_ARGS="${CEPH_EXTRA_RPMBUILD_ARGS} --with crimson"
+        CEPH_EXTRA_RPMBUILD_ARGS="--with crimson"
         CEPH_EXTRA_CMAKE_ARGS+=" -DCMAKE_BUILD_TYPE=Debug"
         DEB_BUILD_PROFILES="pkg.ceph.crimson"
         ;;
@@ -1493,7 +1492,6 @@ setup_rpm_build_deps() {
     # enable more build depends required by build flavor(jaeger, crimson)
     case "${FLAVOR}" in
     crimson)
-      sed -i -e 's/%bcond_with seastar/%bcond_without seastar/g' $DIR/ceph.spec
       sed -i -e 's/%bcond_with crimson/%bcond_without crimson/g' $DIR/ceph.spec
         ;;
     jaeger)