From: Rishabh Dave <ridave@redhat.com>
Date: Thu, 26 Sep 2024 19:11:25 +0000 (+0530)
Subject: mgr/mgr_util: don't set event when it is already set
X-Git-Tag: v20.0.0~809^2~1
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=21cf769ae78021cf6968666ab7dc5e779835fd01;p=ceph.git

mgr/mgr_util: don't set event when it is already set

In class RTimer in mgr_util.py, "self.finished.set()" is run even though
the event self.finished was set just now. If it wasn't set, the while
loop the precedes it would've never finished running. Therefore, remove
this redundant line of code.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
---

diff --git a/src/pybind/mgr/mgr_util.py b/src/pybind/mgr/mgr_util.py
index 67246545eea0f..a999b6525e9f1 100644
--- a/src/pybind/mgr/mgr_util.py
+++ b/src/pybind/mgr/mgr_util.py
@@ -88,7 +88,6 @@ class RTimer(Timer):
             while not self.finished.is_set():
                 self.finished.wait(self.interval)
                 self.function(*self.args, **self.kwargs)
-            self.finished.set()
         except Exception as e:
             logger.error("task exception: %s", e)
             raise