From: Sage Weil <sage@redhat.com>
Date: Fri, 29 Aug 2014 23:10:16 +0000 (-0700)
Subject: Merge remote-tracking branch 'gh/wip-7988'
X-Git-Tag: v0.86~167
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=21e25e77c25e3161f57dd23b46b98a0d8fed3294;p=ceph.git

Merge remote-tracking branch 'gh/wip-7988'

Conflicts:
	src/mds/RecoveryQueue.cc

Reviewed-by: Sage Weil <sage@redhat.com>
---

21e25e77c25e3161f57dd23b46b98a0d8fed3294
diff --cc src/mds/RecoveryQueue.cc
index f811c2c88fef,5968c5100e48..7d10d7b28afe
--- a/src/mds/RecoveryQueue.cc
+++ b/src/mds/RecoveryQueue.cc
@@@ -53,67 -52,39 +53,67 @@@ public
   */
  void RecoveryQueue::advance()
  {
 -  dout(10) << "RecoveryQueue::advance " << file_recover_queue.size() << " queued, "
 +  dout(10) << file_recover_queue.size() << " queued, "
 +	   << file_recover_queue_front.size() << " prioritized, "
  	   << file_recovering.size() << " recovering" << dendl;
  
 -  while (file_recovering.size() < 5 &&
 -	 !file_recover_queue.empty()) {
 -    CInode *in = *file_recover_queue.begin();
 -    file_recover_queue.erase(in);
 +  while (file_recovering.size() < g_conf->mds_max_file_recover) {
 +    if (!file_recover_queue_front.empty()) {
 +      CInode *in = *file_recover_queue_front.begin();
 +      file_recover_queue_front.erase(file_recover_queue_front.begin());
 +      file_recover_queue.erase(in);
 +      _start(in);
 +    } else if (!file_recover_queue.empty()) {
 +      CInode *in = *file_recover_queue.begin();
 +      file_recover_queue.erase(file_recover_queue.begin());
 +      _start(in);
 +    } else {
 +      break;
 +    }
 +  }
 +}
  
 -    inode_t *pi = in->get_projected_inode();
 +void RecoveryQueue::_start(CInode *in)
 +{
 +  inode_t *pi = in->get_projected_inode();
  
 -    // blech
 -    if (pi->client_ranges.size() && !pi->get_max_size()) {
 -      mds->clog->warn() << "bad client_range " << pi->client_ranges
 -	  << " on ino " << pi->ino << "\n";
 -    }
 +  // blech
 +  if (pi->client_ranges.size() && !pi->get_max_size()) {
-     mds->clog.warn() << "bad client_range " << pi->client_ranges
- 		     << " on ino " << pi->ino << "\n";
++    mds->clog->warn() << "bad client_range " << pi->client_ranges
++		      << " on ino " << pi->ino << "\n";
 +  }
  
 -    if (pi->client_ranges.size() && pi->get_max_size()) {
 -      dout(10) << "do_file_recover starting " << in->inode.size << " " << pi->client_ranges
 -	       << " " << *in << dendl;
 -      file_recovering.insert(in);
 +  if (pi->client_ranges.size() && pi->get_max_size()) {
 +    dout(10) << "starting " << in->inode.size << " " << pi->client_ranges
 +	     << " " << *in << dendl;
 +    file_recovering.insert(in);
 +
 +    C_MDC_Recover *fin = new C_MDC_Recover(this, in);
 +    mds->filer->probe(in->inode.ino, &in->inode.layout, in->last,
 +		      pi->get_max_size(), &fin->size, &fin->mtime, false,
 +		      0, fin);
 +  } else {
 +    dout(10) << "skipping " << in->inode.size << " " << *in << dendl;
 +    in->state_clear(CInode::STATE_RECOVERING);
 +    mds->locker->eval(in, CEPH_LOCK_IFILE);
 +    in->auth_unpin(this);
 +  }
 +}
  
 -      C_MDC_Recover *fin = new C_MDC_Recover(this, in);
 -      mds->filer->probe(in->inode.ino, &in->inode.layout, in->last,
 -			pi->get_max_size(), &fin->size, &fin->mtime, false,
 -			0, fin);
 -    } else {
 -      dout(10) << "do_file_recover skipping " << in->inode.size
 -	       << " " << *in << dendl;
 -      in->state_clear(CInode::STATE_RECOVERING);
 -      mds->locker->eval(in, CEPH_LOCK_IFILE);
 -      in->auth_unpin(this);
 -    }
 +void RecoveryQueue::prioritize(CInode *in)
 +{
 +  if (file_recovering.count(in)) {
 +    dout(10) << "already working on " << *in << dendl;
 +    return;
 +  }
 +
 +  if (file_recover_queue.count(in)) {
 +    dout(20) << *in << dendl;
 +    file_recover_queue_front.insert(in);
 +    return;
    }
 +
 +  dout(10) << "not queued " << *in << dendl;
  }
  
  
diff --cc src/mon/OSDMonitor.cc
index 2a3de20ffa45,925081b9c124..ba74a1b118e0
--- a/src/mon/OSDMonitor.cc
+++ b/src/mon/OSDMonitor.cc
@@@ -3294,14 -3295,14 +3294,14 @@@ int OSDMonitor::parse_erasure_code_prof
  					   map<string,string> *erasure_code_profile_map,
  					   stringstream &ss)
  {
-   int r = get_str_map(g_conf->osd_pool_default_erasure_code_profile,
- 		      ss,
- 		      erasure_code_profile_map);
+   int r = get_json_str_map(g_conf->osd_pool_default_erasure_code_profile,
+ 		           ss,
+ 		           erasure_code_profile_map);
    if (r)
      return r;
 -  (*erasure_code_profile_map)["directory"] =
 -    g_conf->osd_pool_default_erasure_code_directory;
 -
 +  assert((*erasure_code_profile_map).count("plugin"));
 +  string default_plugin = (*erasure_code_profile_map)["plugin"];
 +  map<string,string> user_map;
    for (vector<string>::const_iterator i = erasure_code_profile.begin();
         i != erasure_code_profile.end();
         ++i) {