From: Ilya Dryomov <idryomov@gmail.com>
Date: Mon, 6 Feb 2023 16:56:00 +0000 (+0100)
Subject: mon/MgrMap: dump last_failure_osd_epoch and active_clients at top level
X-Git-Tag: v17.2.6~30^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=22af85105fbe5b0baee62dc4114dc528759ad3f1;p=ceph.git

mon/MgrMap: dump last_failure_osd_epoch and active_clients at top level

Currently last_failure_osd_epoch and active_clients are dumped in the
always_on_modules dictionary in "ceph mgr dump" output.  This goes back
to when these fields were added in commits f2986a4400bb ("mon/MgrMonitor:
blacklist previous instance") and df507cde8d71 ("mgr: forward RADOS
client instances for potential blacklist") but is wrong as these fields
have nothing to do with always-on modules.

Fixes: https://tracker.ceph.com/issues/58647
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 7b5e16130afc4b89c934fb95c805eb2e369cd29a)

Conflicts:
	PendingReleaseNotes [ moved to >=17.2.6 section ]
---

diff --git a/PendingReleaseNotes b/PendingReleaseNotes
index 452f7c2770455..3a889ffd2cbc1 100644
--- a/PendingReleaseNotes
+++ b/PendingReleaseNotes
@@ -1,3 +1,10 @@
+>=17.2.6
+--------
+
+* `ceph mgr dump` command now outputs `last_failure_osd_epoch` and
+  `active_clients` fields at the top level.  Previously, these fields were
+  output under `always_on_modules` field.
+
 >=17.2.5
 --------
 
diff --git a/src/mon/MgrMap.h b/src/mon/MgrMap.h
index 5342fc51fc3de..c06a691b04add 100644
--- a/src/mon/MgrMap.h
+++ b/src/mon/MgrMap.h
@@ -514,13 +514,13 @@ public:
       }
       f->close_section();
     }
+    f->close_section(); // always_on_modules
     f->dump_int("last_failure_osd_epoch", last_failure_osd_epoch);
     f->open_array_section("active_clients");
     for (const auto &c : clients) {
       f->dump_object("client", c);
     }
-    f->close_section();
-    f->close_section();
+    f->close_section(); // active_clients
   }
 
   static void generate_test_instances(std::list<MgrMap*> &l) {