From: Casey Bodley <cbodley@redhat.com>
Date: Thu, 30 Jan 2025 17:31:35 +0000 (-0500)
Subject: qa/rgw: fix user cleanup in s3tests task
X-Git-Tag: v20.3.0~460^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2390788b89037bf5121adf4251b980dc20a8f269;p=ceph.git

qa/rgw: fix user cleanup in s3tests task

the if condition was backwards, preventing non-keystone users from being
removed after the s3tests task runs

Fixes: https://tracker.ceph.com/issues/69741

Signed-off-by: Casey Bodley <cbodley@redhat.com>
---

diff --git a/qa/tasks/s3tests.py b/qa/tasks/s3tests.py
index 85ab97d23cd26..383f4736302fb 100644
--- a/qa/tasks/s3tests.py
+++ b/qa/tasks/s3tests.py
@@ -251,7 +251,7 @@ def create_users(ctx, config, s3tests_conf):
         for client in config.keys():
             for section, user in users.items():
                 # don't need to delete keystone users
-                if not user in keystone_users:
+                if section in keystone_users:
                     continue
                 uid = '{user}.{client}'.format(user=user, client=client)
                 cluster_name, daemon_type, client_id = teuthology.split_role(client)