From: Satoru Takeuchi <satoru.takeuchi@gmail.com>
Date: Thu, 18 Nov 2021 20:48:18 +0000 (+0000)
Subject: osd: make osd_fast_shutdown_notify_mon option true by default
X-Git-Tag: v15.2.17~69^2~1
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=2560462fb42536b1569f4bbaf63c3f8afbec57f2;p=ceph.git

osd: make osd_fast_shutdown_notify_mon option true by default

osd_fast_shutdown_notify_mon option is false by default. So users suffer
from error log flood, slow ops, and the long I/O timeouts on voluntary OS
shutdown before they are aware of the existence of this option. Let's
make this option true by default.

Fixes: https://tracker.ceph.com/issues/53328

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
(cherry picked from commit 729a5b85a6586b47d16acbba2cf8e765e498cd65)

 Conflicts:
	src/common/options/global.yaml.in
		- global.yaml.in does not exist in Octopus; rather,
		  these configs were handled in options.cc.
---

diff --git a/src/common/options.cc b/src/common/options.cc
index d2cd2cafc6a33..df346525fe59c 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -3600,7 +3600,7 @@ std::vector<Option> get_global_options() {
     .set_long_description("Setting this to false makes the OSD do a slower teardown of all state when it receives a SIGINT or SIGTERM or when shutting down for any other reason.  That slow shutdown is primarilyy useful for doing memory leak checking with valgrind."),
 
     Option("osd_fast_shutdown_notify_mon", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
-    .set_default(false)
+    .set_default(true)
     .set_description("Tell mon about OSD shutdown on immediate shutdown")
     .set_long_description("Tell the monitor the OSD is shutting down on immediate shutdown. This helps with cluster log messages from other OSDs reporting it immediately failed.")
     .add_see_also({"osd_fast_shutdown", "osd_mon_shutdown_timeout"}),