From: Tomer Haskalovitch <tomer.haska@ibm.com>
Date: Thu, 9 Oct 2025 06:33:57 +0000 (+0300)
Subject: mgr/dashboard: change the default max namespace from 4096 to None in subsystem add... 
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=257abe63cb349be9f6d9fc4ca799ab4546b3b078;p=ceph-ci.git

mgr/dashboard: change the default max namespace from 4096 to None in subsystem add command to take gw default

Resolves: rhbz#2402658

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 97f54b081537e0ee99317927d8da850b72e4415f)
---

diff --git a/src/pybind/mgr/dashboard/controllers/nvmeof.py b/src/pybind/mgr/dashboard/controllers/nvmeof.py
index b1f00442b0b..1d04b75b529 100644
--- a/src/pybind/mgr/dashboard/controllers/nvmeof.py
+++ b/src/pybind/mgr/dashboard/controllers/nvmeof.py
@@ -227,7 +227,7 @@ else:
             parameters={
                 "nqn": Param(str, "NVMeoF subsystem NQN"),
                 "enable_ha": Param(bool, "Enable high availability", True, None),
-                "max_namespaces": Param(int, "Maximum number of namespaces", True, 4096),
+                "max_namespaces": Param(int, "Maximum number of namespaces", True, None),
                 "no_group_append": Param(int, "Do not append gateway group name to the NQN",
                                          True, False),
                 "serial_number": Param(int, "Subsystem serial number", True, None),
@@ -239,7 +239,7 @@ else:
         @convert_to_model(model.SubsystemStatus)
         @handle_nvmeof_error
         def create(self, nqn: str, enable_ha: Optional[bool] = True,
-                   max_namespaces: Optional[int] = 4096, no_group_append: Optional[bool] = False,
+                   max_namespaces: Optional[int] = None, no_group_append: Optional[bool] = False,
                    serial_number: Optional[str] = None, dhchap_key: Optional[str] = None,
                    gw_group: Optional[str] = None, traddr: Optional[str] = None):
             return NVMeoFClient(gw_group=gw_group, traddr=traddr).stub.create_subsystem(
diff --git a/src/pybind/mgr/dashboard/openapi.yaml b/src/pybind/mgr/dashboard/openapi.yaml
index 0d903839950..20a76988ad7 100755
--- a/src/pybind/mgr/dashboard/openapi.yaml
+++ b/src/pybind/mgr/dashboard/openapi.yaml
@@ -9299,7 +9299,6 @@ paths:
                   description: NVMeoF gateway group
                   type: string
                 max_namespaces:
-                  default: 4096
                   description: Maximum number of namespaces
                   type: integer
                 no_group_append: