From: Samuel Just <sjust@redhat.com>
Date: Mon, 4 Apr 2016 23:48:28 +0000 (-0700)
Subject: FileStore::set_xattr_limits_via_conf: add warning if max xattr size smaller than... 
X-Git-Tag: v10.1.2~7^2~5
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=25f937e3640f8bbd14403ba901c6fb327bc73983;p=ceph.git

FileStore::set_xattr_limits_via_conf: add warning if max xattr size smaller than max name

Signed-off-by: Samuel Just <sjust@redhat.com>
---

diff --git a/src/os/filestore/FileStore.cc b/src/os/filestore/FileStore.cc
index e3a77ca61239..95a4f5f7f0c2 100644
--- a/src/os/filestore/FileStore.cc
+++ b/src/os/filestore/FileStore.cc
@@ -5713,6 +5713,18 @@ void FileStore::set_xattr_limits_via_conf()
     m_filestore_max_xattr_value_size = g_conf->filestore_max_xattr_value_size;
   else
     m_filestore_max_xattr_value_size = fs_xattr_max_value_size;
+
+  if (m_filestore_max_xattr_value_size < g_conf->osd_max_object_name_len) {
+    derr << "WARNING: max attr value size ("
+	 << m_filestore_max_xattr_value_size
+	 << ") is smaller than osd_max_object_name_len ("
+	 << g_conf->osd_max_object_name_len
+	 << ").  Your backend filesystem appears to not support attrs large "
+	 << "enough to handle the configured max rados name size.  You may get "
+	 << "unexpected ENAMETOOLONG errors on rados operations or buggy "
+	 << "behavior"
+	 << dendl;
+  }
 }
 
 // -- FSSuperblock --