From: Omer Zilberberg <omzg@plexistor.com>
Date: Tue, 26 May 2015 02:51:57 +0000 (+1000)
Subject: _require_command: quote commands correctly
X-Git-Tag: v2022.05.01~2870
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=262442515c298b40e2b747981ec08daec3b510fb;p=xfstests-dev.git

_require_command: quote commands correctly

fixes 9435b92 common: _require_command needs to handle parameters

Also quoted $_command because _require_command may be called with an
empty $1 parameter, e.g.:
_require_command "$MY_UTIL_PROG" my_util  # but $MY_UTIL_PROG is empty

[ -x ] returns true.
[ -x "" ] returns false, as required here.

Signed-off-by: Omer Zilberberg <omzg@plexistor.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---

diff --git a/common/rc b/common/rc
index 900b6e55..c31538de 100644
--- a/common/rc
+++ b/common/rc
@@ -1307,7 +1307,7 @@ _require_command()
 	fi
 
 	_command=`echo "$1" | awk '{ print $1 }'`
-	if [ ! -x $command ]; then
+	if [ ! -x "$_command" ]; then
 		_notrun "$_name utility required, skipped this test"
 	fi
 }