From: Abhishek Lekshmanan <abhishek@suse.com>
Date: Tue, 3 Dec 2019 17:58:29 +0000 (+0100)
Subject: rgw: public access: drop unused function
X-Git-Tag: v15.1.1~555^2~4
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=2831d4876b304a4274dceb841e2e17348dffc627;p=ceph-ci.git

rgw: public access: drop unused function

Also cleanup the comment to mention why we've deviated from the spec here

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
---

diff --git a/src/rgw/rgw_public_access.cc b/src/rgw/rgw_public_access.cc
index 3197b75c522..2e1315a26d4 100644
--- a/src/rgw/rgw_public_access.cc
+++ b/src/rgw/rgw_public_access.cc
@@ -10,11 +10,9 @@ void PublicAccessBlockConfiguration::decode_xml(XMLObj *obj) {
 
 void PublicAccessBlockConfiguration::dump_xml(Formatter *f) const {
   Formatter::ObjectSection os(*f, "BlockPublicAccessBlockConfiguration");
-  // AWS spec mentions the values to be ALL CAPs, but clients will not
-  // understand this or a mixed case like it is supposed to, hence the need to
-  // manually encode here
-  auto bool_val = [](bool b) -> auto { return b ? "true": "false"; };
-
+  // Note: AWS spec mentions the values to be ALL CAPs, but clients seem to
+  // require all small letters, and S3 itself doesn't seem to follow the API
+  // spec here
   f->dump_bool("BlockPublicAcls", BlockPublicAcls);
   f->dump_bool("IgnorePublicAcls", IgnorePublicAcls);
   f->dump_bool("BlockPublicPolicy", BlockPublicPolicy);