From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Tue, 12 Feb 2013 16:25:00 +0000 (+0100)
Subject: mds/CDentry.h: use projected.empty() instead of projected.size()
X-Git-Tag: v0.58~54^2~4
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=28bf6cbab6a34451a4008fd89f1b071fe65731c7;p=ceph.git

mds/CDentry.h: use projected.empty() instead of projected.size()

Use empty() since it should be prefered as it has, following the
standard, a constant time complexity regardless of the containter
type. The same is not guaranteed for size().

warning from cppchecker was:
[src/mds/CDentry.h:234]: (performance) Possible inefficient
  checking for 'projected' emptiness.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/mds/CDentry.h b/src/mds/CDentry.h
index aa10bf97118e..d07ef066acd0 100644
--- a/src/mds/CDentry.h
+++ b/src/mds/CDentry.h
@@ -231,7 +231,7 @@ public:
   bool is_projected() { return projected.size(); }
 
   linkage_t *get_projected_linkage() {
-    if (projected.size())
+    if (!projected.empty())
       return &projected.back();
     return &linkage;
   }