From: Jan Kara Date: Tue, 14 May 2013 12:02:50 +0000 (-0500) Subject: Make test 306 use null and zero device nodes on SCRATCH_MNT X-Git-Tag: v2022.05.01~3436 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2941898570ccdb32ab5af89c0b25147231489973;p=xfstests-dev.git Make test 306 use null and zero device nodes on SCRATCH_MNT In one place of test 306, we mistakenly used /dev/null and /dev/zero instead of equivalent devices created on tested filesystem. So we were not really testing the functionality we intended. Signed-off-by: Jan Kara Reviewed-by: Eric Sandeen Signed-off-by: Rich Johnston -- --- diff --git a/tests/generic/306 b/tests/generic/306 index e8e0fc0a..f45d1427 100644 --- a/tests/generic/306 +++ b/tests/generic/306 @@ -73,9 +73,9 @@ _scratch_mount -o ro || _fail "Could not mount scratch readonly" echo "== try to create new file" touch $SCRATCH_MNT/this_should_fail 2>&1 | _filter_scratch echo "== pwrite to null device" -$XFS_IO_PROG -F -c "pwrite 0 512" /dev/null | _filter_xfs_io +$XFS_IO_PROG -F -c "pwrite 0 512" $DEVNULL | _filter_xfs_io echo "== pread from zero device" -$XFS_IO_PROG -F -c "pread 0 512" /dev/zero | _filter_xfs_io +$XFS_IO_PROG -F -c "pread 0 512" $DEVZERO | _filter_xfs_io echo "== truncating write to null device" echo foo > $DEVNULL 2>&1 | _filter_scratch