From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Fri, 31 May 2013 16:28:07 +0000 (+0200)
Subject: mds/Locker.cc: fix explicit null dereferenced
X-Git-Tag: v0.65~168^2~16
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2a024091831ba194b68d716f0a9104972aa520d5;p=ceph.git

mds/Locker.cc: fix explicit null dereferenced

CID 716916 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
  var_deref_model: Passing null pointer "in" to function
  "CInode::is_head()", which dereferences it.

Add assert.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/mds/Locker.cc b/src/mds/Locker.cc
index 57154b3d9f6d..127db262b462 100644
--- a/src/mds/Locker.cc
+++ b/src/mds/Locker.cc
@@ -615,6 +615,7 @@ void Locker::eval_gather(SimpleLock *lock, bool first, bool *pneed_issue, list<C
   bool need_issue = false;
 
   int loner_issued = 0, other_issued = 0, xlocker_issued = 0;
+  assert(!caps || in != NULL);
   if (caps && in->is_head()) {
     in->get_caps_issued(&loner_issued, &other_issued, &xlocker_issued,
 			lock->get_cap_shift(), lock->get_cap_mask());