From: Jan Kara <jack@suse.cz>
Date: Mon, 24 May 2010 09:46:44 +0000 (+0200)
Subject: Fix fallocate() test
X-Git-Tag: v1.1.0~162^2~7
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2a7c4917c977bc040bfced0a28aaa3f52c05a2e0;p=xfstests-dev.git

Fix fallocate() test

The test for fallocate was broken because it used $TEST_DIR/$tmp.io. Because
$tmp is usually something like /tmp/1234 or /mnt/1234 the file cannot be
created and xfs_io fails regardless of existance of fallocate support. Moreover
the subsequent message parsing decides that fallocate is actually supported
because it does not expect this message.

Fix the test to not use $tmp.

Signed-off-by: Jan Kara <jack@suse.cz>
---

diff --git a/common.rc b/common.rc
index e6d818d0..6bf1e127 100644
--- a/common.rc
+++ b/common.rc
@@ -803,8 +803,9 @@ _require_user()
 #
 _require_xfs_io_falloc()
 {
-	testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $TEST_DIR/$tmp.io 2>&1`
-	rm -f $TEST_DIR/$tmp.io 2>&1 > /dev/null
+	testfile=$TEST_DIR/$$.falloc
+	testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1`
+	rm -f $testfile 2>&1 > /dev/null
 	echo $testio | grep -q "not found" && \
 		_notrun "xfs_io fallocate support is missing"
 	echo $testio | grep -q "Operation not supported" && \