From: Yanqin Jin Date: Fri, 3 Jun 2022 17:22:52 +0000 (-0700) Subject: Temporarily disable wal compression (#10108) X-Git-Tag: v7.4.3~77 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2b3c50c42939583aaa507e276b72973e2ff844e3;p=rocksdb.git Temporarily disable wal compression (#10108) Summary: Will re-enable after fixing the bug in https://github.com/facebook/rocksdb/issues/10099 and https://github.com/facebook/rocksdb/issues/10097. Right now, the priority is https://github.com/facebook/rocksdb/issues/10087, but the bug in WAL compression prevents the mini crash test from passing. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10108 Reviewed By: pdillinger Differential Revision: D36897214 Pulled By: riversand963 fbshipit-source-id: d64dc52738222d5f66003f7731dc46eaeed812be --- diff --git a/tools/db_crashtest.py b/tools/db_crashtest.py index 3f745030d..b1187f865 100644 --- a/tools/db_crashtest.py +++ b/tools/db_crashtest.py @@ -174,7 +174,9 @@ default_params = { "detect_filter_construct_corruption": lambda: random.choice([0, 1]), "adaptive_readahead": lambda: random.choice([0, 1]), "async_io": lambda: random.choice([0, 1]), - "wal_compression": lambda: random.choice(["none", "zstd"]), + # Temporarily disable wal compression because it causes backup/checkpoint to miss + # compressed WAL files. + "wal_compression": "none", "verify_sst_unique_id_in_manifest": 1, # always do unique_id verification "secondary_cache_uri": "", }