From: Josh Durgin <josh.durgin@inktank.com>
Date: Mon, 24 Sep 2012 22:20:14 +0000 (-0700)
Subject: secret: close fd on error
X-Git-Tag: v0.53~60^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2c1b7f2c5ddce3e362b451ed39a18306f1896eb3;p=ceph.git

secret: close fd on error

CID 717079: Resource leak (RESOURCE_LEAK)
At (6): Handle variable "fd" going out of scope leaks the handle.

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
---

diff --git a/src/common/secret.c b/src/common/secret.c
index 0d2cfb61e379f..f37619a72dad2 100644
--- a/src/common/secret.c
+++ b/src/common/secret.c
@@ -38,6 +38,7 @@ int read_secret_from_file(const char *filename, char *secret, size_t max_len)
   len = safe_read(fd, secret, max_len);
   if (len <= 0) {
     perror("unable to read secret from file");
+    close(fd);
     return -1;
   }
   end = secret;