From: Alfredo Deza <alfredo.deza@inktank.com>
Date: Tue, 26 Nov 2013 15:55:48 +0000 (-0600)
Subject: add a note about  for tmp files
X-Git-Tag: v1.3.3~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2d9c452332d51f550abb2a189c1a3621a20c504a;p=ceph-deploy.git

add a note about  for tmp files

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
---

diff --git a/ceph_deploy/hosts/remotes.py b/ceph_deploy/hosts/remotes.py
index 5317f34..2f5e544 100644
--- a/ceph_deploy/hosts/remotes.py
+++ b/ceph_deploy/hosts/remotes.py
@@ -69,6 +69,9 @@ def write_conf(cluster, conf, overwrite):
 
 def write_keyring(path, key):
     """ create a keyring file """
+    # Note that we *require* to avoid deletion of the temp file
+    # otherwise we risk not being able to copy the contents from
+    # one file system to the other, hence the `delete=False`
     tmp_file = tempfile.NamedTemporaryFile(delete=False)
     tmp_file.write(key)
     tmp_file.close()