From: Sage Weil <sage@redhat.com>
Date: Wed, 19 Aug 2015 13:38:25 +0000 (-0400)
Subject: client: consolidate client_mount_{uid,gid} and client_{user,group}_id options
X-Git-Tag: v10.0.0~123^2~19
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2df9bfb4cf211c03dec68340adf0da7b11fcabe3;p=ceph.git

client: consolidate client_mount_{uid,gid} and client_{user,group}_id options

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/client/Client.cc b/src/client/Client.cc
index d351e5f5fed5..8d3fd279b48a 100644
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -266,8 +266,8 @@ Client::Client(Messenger *m, MonClient *mc)
   _dir_vxattrs_name_size = _vxattrs_calcu_name_size(_dir_vxattrs);
   _file_vxattrs_name_size = _vxattrs_calcu_name_size(_file_vxattrs);
 
-  user_id = cct->_conf->client_user_id;
-  group_id = cct->_conf->client_group_id;
+  user_id = cct->_conf->client_mount_uid;
+  group_id = cct->_conf->client_mount_gid;
 
   lru.lru_set_max(cct->_conf->client_cache_size);
   lru.lru_set_midpoint(cct->_conf->client_cache_mid);
@@ -5053,7 +5053,7 @@ int Client::mount(const std::string &mount_root, bool require_mds)
     MetaRequest *req = new MetaRequest(CEPH_MDS_OP_GETATTR);
     req->set_filepath(fp);
     req->head.args.getattr.mask = CEPH_STAT_CAP_INODE_ALL;
-    int res = make_request(req, cct->_conf->client_mount_uid, cct->_conf->client_mount_gid);
+    int res = make_request(req, -1, -1);
     if (res < 0) {
       if (res == -EACCES && root) {
 	ldout(cct, 1) << __func__ << " EACCES on parent of mount point; quotas may not work" << dendl;
diff --git a/src/common/config_opts.h b/src/common/config_opts.h
index b34ea3f1469a..78d74ccaa3e3 100644
--- a/src/common/config_opts.h
+++ b/src/common/config_opts.h
@@ -367,8 +367,6 @@ OPTION(fuse_debug, OPT_BOOL, false)
 OPTION(fuse_multithreaded, OPT_BOOL, true)
 OPTION(fuse_require_active_mds, OPT_BOOL, true) // if ceph_fuse requires active mds server
 
-OPTION(client_user_id, OPT_INT, -1)
-OPTION(client_group_id, OPT_INT, -1)
 OPTION(client_try_dentry_invalidate, OPT_BOOL, true) // the client should try to use dentry invaldation instead of remounting, on kernels it believes that will work for
 OPTION(client_die_on_failed_remount, OPT_BOOL, true)
 OPTION(client_check_pool_perm, OPT_BOOL, true)