From: Venky Shankar <vshankar@redhat.com>
Date: Wed, 12 Mar 2025 05:11:57 +0000 (+0000)
Subject: mds: dout snapdiff snapid's before validation check
X-Git-Tag: testing/wip-vshankar-testing-20250603.055014-reef-debug^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2e8eb48fe30ad5d1488e5d5f52f18c66293c8c1d;p=ceph-ci.git

mds: dout snapdiff snapid's before validation check

As a debug aid when the snapdiff request is erroring out.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit ae9b0350e64e43dfd612b71435c9d288d2669a1e)

 Conflicts:
    src/mds/Server.cc
    - Resolved cherry-pick conflicts
---

diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index 563f339dafc..4b9496fd663 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -11516,6 +11516,11 @@ void Server::handle_client_readdir_snapdiff(MDRequestRef& mdr)
   mdr->set_mds_stamp(now);
 
   mdr->snapid_diff_other = (uint64_t)req->head.args.snapdiff.snap_other;
+  dout(10) << __func__
+    << " snap " << mdr->snapid
+    << " vs. snap " << mdr->snapid_diff_other
+    << dendl;
+
   if (mdr->snapid_diff_other == mdr->snapid ||
       mdr->snapid == CEPH_NOSNAP ||
       mdr->snapid_diff_other == CEPH_NOSNAP) {
@@ -11523,11 +11528,6 @@ void Server::handle_client_readdir_snapdiff(MDRequestRef& mdr)
     respond_to_request(mdr, -CEPHFS_EINVAL);
   }
 
-  dout(10) << __func__
-    << " snap " << mdr->snapid
-    << " vs. snap " << mdr->snapid_diff_other
-    << dendl;
-
   SnapRealm* realm = diri->find_snaprealm();
 
   unsigned max = req->head.args.snapdiff.max_entries;