From: Jason Dillaman <dillaman@redhat.com>
Date: Fri, 17 Jan 2020 13:13:45 +0000 (-0500)
Subject: rbd-mirror: ensure mirror status updater cannot attempt empty op
X-Git-Tag: v15.1.0~175^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2e9bd583a4a7a1c0782de27a23ff433b8b7448e3;p=ceph.git

rbd-mirror: ensure mirror status updater cannot attempt empty op

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
---

diff --git a/src/tools/rbd_mirror/MirrorStatusUpdater.cc b/src/tools/rbd_mirror/MirrorStatusUpdater.cc
index 29dd095c6bd..561741d1420 100644
--- a/src/tools/rbd_mirror/MirrorStatusUpdater.cc
+++ b/src/tools/rbd_mirror/MirrorStatusUpdater.cc
@@ -293,6 +293,11 @@ void MirrorStatusUpdater<I>::update_task(int r) {
   Context* ctx = create_context_callback<
     MirrorStatusUpdater<I>,
     &MirrorStatusUpdater<I>::handle_update_task>(this);
+  if (updating_global_image_ids.empty()) {
+    ctx->complete(0);
+    return;
+  }
+
   auto gather = new C_Gather(g_ceph_context, ctx);
 
   auto it = updating_global_image_ids.begin();