From: Zhang Song <zhangsong02@qianxin.com>
Date: Mon, 12 May 2025 06:36:16 +0000 (+0800)
Subject: crimson/os/seastore/FixedKVBtree: remove with_btree_ret helper function
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=2ea43ec982ca24b492a17cec1baab650d692180b;p=ceph.git

crimson/os/seastore/FixedKVBtree: remove with_btree_ret helper function

Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit 725ec09ee5eead3893cd43ba8706d0836399ca2f)
---

diff --git a/src/crimson/os/seastore/backref/btree_backref_manager.cc b/src/crimson/os/seastore/backref/btree_backref_manager.cc
index bf70daa81f66d..58b4ffd4c9a84 100644
--- a/src/crimson/os/seastore/backref/btree_backref_manager.cc
+++ b/src/crimson/os/seastore/backref/btree_backref_manager.cc
@@ -91,7 +91,7 @@ BtreeBackrefManager::get_mapping(
   LOG_PREFIX(BtreeBackrefManager::get_mapping);
   TRACET("{}", t, offset);
   auto c = get_context(t);
-  return with_btree_ret<BackrefBtree, BackrefMapping>(
+  return with_btree<BackrefBtree>(
     cache,
     c,
     [c, offset](auto &btree) {
@@ -503,7 +503,7 @@ BtreeBackrefManager::remove_mapping(
   paddr_t addr)
 {
   auto c = get_context(t);
-  return with_btree_ret<BackrefBtree, remove_mapping_result_t>(
+  return with_btree<BackrefBtree>(
     cache,
     c,
     [c, addr](auto &btree) mutable {
@@ -574,7 +574,7 @@ BtreeBackrefManager::retrieve_backref_extents_in_range(
 	ent.key);
 
       auto c = get_context(t);
-      return with_btree_ret<BackrefBtree, CachedExtentRef>(
+      return with_btree<BackrefBtree>(
 	cache,
 	c,
 	[c, &ent](auto &btree) {
diff --git a/src/crimson/os/seastore/btree/fixed_kv_btree.h b/src/crimson/os/seastore/btree/fixed_kv_btree.h
index 103e24ad15155..61c0769a06da1 100644
--- a/src/crimson/os/seastore/btree/fixed_kv_btree.h
+++ b/src/crimson/os/seastore/btree/fixed_kv_btree.h
@@ -2204,25 +2204,4 @@ auto with_btree_state(
     cache, c, State{}, std::forward<F>(f));
 }
 
-template <
-  typename tree_type_t,
-  typename Ret,
-  typename F>
-auto with_btree_ret(
-  Cache &cache,
-  op_context_t c,
-  F &&f) {
-  return with_btree_state<tree_type_t, Ret>(
-    cache,
-    c,
-    [f=std::forward<F>(f)](auto &btree, auto &ret) mutable {
-      return f(
-        btree
-      ).si_then([&ret](auto &&_ret) {
-        ret = std::move(_ret);
-      });
-    });
 }
-
-}
-
diff --git a/src/crimson/os/seastore/lba/btree_lba_manager.cc b/src/crimson/os/seastore/lba/btree_lba_manager.cc
index 3c613dbbd27d4..f9e2b2f962a6d 100644
--- a/src/crimson/os/seastore/lba/btree_lba_manager.cc
+++ b/src/crimson/os/seastore/lba/btree_lba_manager.cc
@@ -707,7 +707,7 @@ BtreeLBAManager::get_physical_extent_if_live(
          t, type, laddr, addr, len);
   ceph_assert(is_lba_node(type));
   auto c = get_context(t);
-  return with_btree_ret<LBABtree, CachedExtentRef>(
+  return with_btree<LBABtree>(
     cache,
     c,
     [c, type, addr, laddr, len](auto &btree) {