From: Sage Weil <sage.weil@dreamhost.com>
Date: Sun, 21 Aug 2011 20:56:38 +0000 (-0700)
Subject: mount: avoid unguarded strcpy
X-Git-Tag: v0.35~314
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=2ebf14147fa3091379cd253275cf9fc55af73f2c;p=ceph.git

mount: avoid unguarded strcpy

Use strdup here, mostly to make coverity shut up.

Coverity cid 45

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
---

diff --git a/src/mount/mount.ceph.c b/src/mount/mount.ceph.c
index 34fce4def906..9dafd0d6f33d 100755
--- a/src/mount/mount.ceph.c
+++ b/src/mount/mount.ceph.c
@@ -39,15 +39,16 @@ static char *mount_resolve_src(const char *orig_str)
 	int len, pos;
 	char *mount_path;
 	char *src;
-	char buf[strlen(orig_str) + 1];
-	strcpy(buf, orig_str);
+	char *buf = strdup(orig_str);
 	mount_path = strrchr(buf, ':');
 	if (!mount_path) {
 		printf("source mount path was not specified\n");
+		free(buf);
 		return NULL;
 	}
 	if (mount_path == buf) {
 		printf("server address expected\n");
+		free(buf);
 		return NULL;
 	}
 
@@ -56,10 +57,12 @@ static char *mount_resolve_src(const char *orig_str)
 
 	if (!*mount_path) {
 		printf("incorrect source mount path\n");
+		free(buf);
 		return NULL;
 	}
 
 	src = resolve_addrs(buf);
+	free(buf);
 	if (!src)
 		return NULL;