From: Sage Weil <sage@inktank.com>
Date: Sat, 27 Oct 2012 22:12:16 +0000 (-0700)
Subject: os/FileStore: remove unused _getattrs() methods
X-Git-Tag: v0.55~188^2~13
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=307fd429db8fa6a3e606de14a6617a490dadcba0;p=ceph.git

os/FileStore: remove unused _getattrs() methods

We are now using the _fgetattrs() variant everywhere instead.

Signed-off-by: Sage Weil <sage@inktank.com>
---

diff --git a/src/os/FileStore.cc b/src/os/FileStore.cc
index c6c3f449d987..fc418c8051b1 100644
--- a/src/os/FileStore.cc
+++ b/src/os/FileStore.cc
@@ -3734,119 +3734,6 @@ int FileStore::_getattr(const char *fn, const char *name, bufferptr& bp)
   return l;
 }
 
-// note that this is a clone of the method below.. any change here should be reflected there 
-int FileStore::_getattrs(coll_t cid, const hobject_t& oid, map<string,bufferptr>& aset, bool user_only) 
-{
-  // get attr list
-  char names1[100];
-  int len = lfn_listxattr(cid, oid, names1, sizeof(names1)-1);
-  char *names2 = 0;
-  char *name = 0;
-  if (len == -ERANGE) {
-    len = lfn_listxattr(cid, oid, 0, 0);
-    if (len < 0)
-      return len;
-    dout(10) << " -ERANGE, len is " << len << dendl;
-    names2 = new char[len+1];
-    len = lfn_listxattr(cid, oid, names2, len);
-    dout(10) << " -ERANGE, got " << len << dendl;
-    if (len < 0)
-      return len;
-    name = names2;
-  } else if (len < 0)
-    return len;
-  else
-    name = names1;
-  name[len] = 0;
-
-  char *end = name + len;
-  while (name < end) {
-    char *attrname = name;
-    if (parse_attrname(&name)) {
-      char *set_name = name;
-      bool can_get = true;
-      if (user_only) {
-          if (*set_name =='_')
-            set_name++;
-          else
-            can_get = false;
-      }
-      if (*set_name && can_get) {
-        dout(20) << "getattrs " << cid << "/" << oid << " getting '" << name << "'" << dendl;
-      
-        int r = _getattr(cid, oid, attrname, aset[set_name]);
-        if (r < 0) {
-	  assert(!m_filestore_fail_eio || r != -EIO);
-	  return r;
-	}
-      }
-    }
-    name += strlen(name) + 1;
-  }
-
-  delete[] names2;
-  return 0;
-}
-
-
-// note that this is a clone of the method above.. any change here should be reflected
-// there
-int FileStore::_getattrs(const char *fn, map<string,bufferptr>& aset, bool user_only) 
-{
-  // get attr list
-  char names1[100];
-  int len = chain_listxattr(fn, names1, sizeof(names1)-1);
-  char *names2 = 0;
-  char *name = 0;
-  if (len == -ERANGE) {
-    len = chain_listxattr(fn, 0, 0);
-    if (len < 0) {
-      assert(!m_filestore_fail_eio || len != -EIO);
-      return len;
-    }
-    dout(10) << " -ERANGE, len is " << len << dendl;
-    names2 = new char[len+1];
-    len = chain_listxattr(fn, names2, len);
-    dout(10) << " -ERANGE, got " << len << dendl;
-    if (len < 0) {
-      assert(!m_filestore_fail_eio || len != -EIO);
-      return len;
-    }
-    name = names2;
-  } else if (len < 0) {
-    assert(!m_filestore_fail_eio || len != -EIO);
-    return len;
-  } else {
-    name = names1;
-  }
-  name[len] = 0;
-
-  char *end = name + len;
-  while (name < end) {
-    char *attrname = name;
-    if (parse_attrname(&name)) {
-      char *set_name = name;
-      bool can_get = true;
-      if (user_only) {
-          if (*set_name =='_')
-            set_name++;
-          else
-            can_get = false;
-      }
-      if (*set_name && can_get) {
-        dout(20) << "getattrs " << fn << " getting '" << name << "'" << dendl;
-        //dout(0) << "getattrs " << fn << " set_name '" << set_name << "' user_only=" << user_only << dendl;
-      
-        int r = _getattr(fn, attrname, aset[set_name]);
-        if (r < 0) return r;
-      }
-    }
-    name += strlen(name) + 1;
-  }
-
-  delete[] names2;
-  return 0;
-}
 
 // objects
 
diff --git a/src/os/FileStore.h b/src/os/FileStore.h
index 2d14ed2482c3..66a7de63df43 100644
--- a/src/os/FileStore.h
+++ b/src/os/FileStore.h
@@ -406,9 +406,7 @@ public:
   int getattrs(coll_t cid, const hobject_t& oid, map<string,bufferptr>& aset, bool user_only = false);
 
   int _getattr(coll_t cid, const hobject_t& oid, const char *name, bufferptr& bp);
-  int _getattrs(coll_t cid, const hobject_t& oid, map<string,bufferptr>& aset, bool user_only = false) ;
   int _getattr(const char *fn, const char *name, bufferptr& bp);
-  int _getattrs(const char *fn, map<string,bufferptr>& aset, bool user_only = false);
 
   int _setattrs(coll_t cid, const hobject_t& oid, map<string,bufferptr>& aset,
 		const SequencerPosition &spos);