From: David Zafman Date: Wed, 20 Mar 2019 01:05:11 +0000 (-0700) Subject: test: osd-scrub-repair.sh: use corrupt_and_repair_lrc for lrc tests X-Git-Tag: v15.0.0~76^2~4 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=315d32488963705f28cd51a327281b8940d1e7cd;p=ceph.git test: osd-scrub-repair.sh: use corrupt_and_repair_lrc for lrc tests Fix for argument handling of create_ec_pool() Always pass a value for allow_overwrites for consistency Caused by: 3ca750d41dfe33c6efea4abc96d2bd426a9742b9 Signed-off-by: David Zafman --- diff --git a/qa/standalone/scrub/osd-scrub-repair.sh b/qa/standalone/scrub/osd-scrub-repair.sh index a81ad10e366c..3d587d603190 100755 --- a/qa/standalone/scrub/osd-scrub-repair.sh +++ b/qa/standalone/scrub/osd-scrub-repair.sh @@ -193,7 +193,9 @@ function corrupt_and_repair_erasure_coded() { function create_ec_pool() { local pool_name=$1 - local allow_overwrites=$2 + shift + local allow_overwrites=$1 + shift ceph osd erasure-code-profile set myprofile crush-failure-domain=osd "$@" || return 1 @@ -291,7 +293,7 @@ function corrupt_and_repair_jerasure() { } function TEST_corrupt_and_repair_jerasure_appends() { - corrupt_and_repair_jerasure $1 + corrupt_and_repair_jerasure $1 false } function TEST_corrupt_and_repair_jerasure_overwrites() { @@ -325,12 +327,12 @@ function corrupt_and_repair_lrc() { } function TEST_corrupt_and_repair_lrc_appends() { - corrupt_and_repair_jerasure $1 + corrupt_and_repair_lrc $1 false } function TEST_corrupt_and_repair_lrc_overwrites() { if [ "$use_ec_overwrite" = "true" ]; then - corrupt_and_repair_jerasure $1 true + corrupt_and_repair_lrc $1 true fi } @@ -393,7 +395,7 @@ function unfound_erasure_coded() { } function TEST_unfound_erasure_coded_appends() { - unfound_erasure_coded $1 + unfound_erasure_coded $1 false } function TEST_unfound_erasure_coded_overwrites() {