From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Wed, 19 Feb 2014 16:55:17 +0000 (+0100)
Subject: OSDMonitor: use !empty() instead of size() > 0
X-Git-Tag: v0.78~138^2~14
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=31b4107adb4914fca10a16e2104d55b3d0e73cfb;p=ceph.git

OSDMonitor: use !empty() instead of size() > 0

[src/mon/OSDMonitor.cc:730]: (performance) Possible inefficient checking
  for 'osd_weight' emptiness.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc
index b25c4248babd..d3bd7af1a474 100644
--- a/src/mon/OSDMonitor.cc
+++ b/src/mon/OSDMonitor.cc
@@ -727,7 +727,7 @@ bool OSDMonitor::should_propose(double& delay)
     return true;
 
   // adjust osd weights?
-  if (osd_weight.size() > 0 &&
+  if (!osd_weight.empty() &&
       osd_weight.size() == (unsigned)osdmap.get_max_osd()) {
     dout(0) << " adjusting osd weights based on " << osd_weight << dendl;
     osdmap.adjust_osd_weights(osd_weight, pending_inc);