From: Radosław Zarzyński <rzarzyns@redhat.com>
Date: Tue, 1 Aug 2023 13:52:55 +0000 (+0200)
Subject: crimson/osd: add support for MOSDECSubOpRead
X-Git-Tag: v21.0.0~3^2~92
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=32ab54a9ab7b271bdd3c65f51ea104787ea608f5;p=ceph.git

crimson/osd: add support for MOSDECSubOpRead

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
---

diff --git a/src/crimson/osd/ec_backend.cc b/src/crimson/osd/ec_backend.cc
index be3a73843cbe..09d0516fd121 100644
--- a/src/crimson/osd/ec_backend.cc
+++ b/src/crimson/osd/ec_backend.cc
@@ -1,6 +1,7 @@
-#include "ec_backend.h"
+#include <boost/iterator/counting_iterator.hpp>
 
 #include "crimson/osd/shard_services.h"
+#include "ec_backend.h"
 
 namespace crimson::osd {
 
@@ -9,10 +10,12 @@ ECBackend::ECBackend(shard_id_t shard,
                      crimson::osd::ShardServices& shard_services,
                      store_index_t store_index,
                      const ec_profile_t&,
-                     uint64_t,
+                     uint64_t stripe_width,
 		     DoutPrefixProvider &dpp)
-  : PGBackend{shard, coll, shard_services, store_index, dpp}
+  : PGBackend{shard, coll, shard_services, store_index, dpp},
+    sinfo{ec_impl->get_data_chunk_count(), stripe_width}
 {
+  // FIXME: ec_impl
   // todo
 }
 
@@ -51,10 +54,86 @@ ECBackend::handle_rep_write_reply(Ref<MOSDECSubOpWriteReply>)
   return write_iertr::now();
 }
 
+bool ECBackend::is_single_chunk(const hobject_t& obj, const ECSubRead& op)
+{
+  return (op.subchunks.find(obj)->second.size() == 1) &&
+    (op.subchunks.find(obj)->second.front().second ==
+      ec_impl->get_sub_chunk_count());
+}
+
+ECBackend::ll_read_errorator::future<ceph::bufferlist>
+ECBackend::maybe_chunked_read(
+  const hobject_t& obj,
+  const ECSubRead& op,
+  const uint64_t off,
+  const uint64_t size,
+  const uint32_t flags)
+{
+  LOG_PREFIX(ECBackend::maybe_chunked_read);
+  DEBUG("obj {} off {} size {} flags {}", obj, off, size, flags);
+  DEBUG("oid is: {}", ghobject_t{obj, ghobject_t::NO_GEN, get_shard()});
+  if (is_single_chunk(obj, op)) {
+    return store->read(
+      coll, ghobject_t{obj, ghobject_t::NO_GEN, get_shard()}, off, size, flags);
+  } else {
+    return seastar::do_with(ceph::bufferlist{}, [=, this] (auto&& result_bl) {
+      const int subchunk_size =
+        sinfo.get_chunk_size() / ec_impl->get_sub_chunk_count();
+      return crimson::do_for_each(
+        boost::make_counting_iterator(0UL),
+        boost::make_counting_iterator(1 + (size-1) / sinfo.get_chunk_size()),
+        [off, flags, subchunk_size, &obj, &op, &result_bl, this] (const auto m) {
+          const auto& sub_spec = op.subchunks.find(obj)->second;
+          return crimson::do_for_each(
+            std::begin(sub_spec),
+            std::end(sub_spec),
+            [&obj, off, flags, subchunk_size, m, &result_bl, this] (const auto& subchunk) {
+              const auto [sub_off_count, sub_size_count] = subchunk;
+              return store->read(
+                coll,
+                ghobject_t{obj, ghobject_t::NO_GEN, get_shard()},
+                off + m*sinfo.get_chunk_size() + sub_off_count*subchunk_size,
+                sub_size_count * subchunk_size,
+                flags
+              ).safe_then([&result_bl] (auto&& sub_bl) {
+		result_bl.claim_append(sub_bl);
+                return ll_read_errorator::now();
+              });
+            }
+          );
+        }
+      ).safe_then([&result_bl] {
+        return ll_read_errorator::make_ready_future<ceph::bufferlist>(
+          std::move(result_bl));
+      });
+    });
+  }
+}
+
 ECBackend::ll_read_ierrorator::future<>
 ECBackend::handle_rep_read_op(Ref<MOSDECSubOpRead> m)
 {
-  return ll_read_ierrorator::now();
+  return seastar::do_with(ECSubReadReply{},
+		          [m=std::move(m), this] (auto&& reply) {
+    const ECSubRead &op = m->op;
+    reply.from = whoami;
+    reply.tid = op.tid;
+    return interruptor::do_for_each(op.to_read, [&op, &reply, this] (auto read_item) {
+      const auto& [obj, op_list] = read_item;
+      return interruptor::do_for_each(op_list, [&op, &reply, obj, this] (auto op_spec) {
+        using read_errorator = crimson::os::FuturizedStore::Shard::read_errorator;
+        const auto& [off, size, flags] = op_spec;
+        return maybe_chunked_read(
+          obj, op, off, size, flags
+        ).safe_then([&reply] (auto bl) {
+          return ll_read_ierrorator::now();
+        }, read_errorator::all_same_way([] (const auto& e) {
+	assert(e.value() > 0);
+          return ll_read_ierrorator::now();
+        }));
+      });
+    });
+  });
 }
 
 ECBackend::ll_read_ierrorator::future<>
diff --git a/src/crimson/osd/ec_backend.h b/src/crimson/osd/ec_backend.h
index 785d70924da4..cce9384b766c 100644
--- a/src/crimson/osd/ec_backend.h
+++ b/src/crimson/osd/ec_backend.h
@@ -5,11 +5,13 @@
 
 #include <boost/intrusive_ptr.hpp>
 #include <seastar/core/future.hh>
+#include "erasure-code/ErasureCodeInterface.h"
 #include "include/buffer_fwd.h"
 #include "messages/MOSDECSubOpWrite.h"
 #include "messages/MOSDECSubOpWriteReply.h"
 #include "messages/MOSDECSubOpRead.h"
 #include "messages/MOSDECSubOpReadReply.h"
+#include "osd/ECUtil.h"
 #include "osd/osd_types.h"
 #include "pg_backend.h"
 
@@ -50,6 +52,18 @@ private:
 				       const eversion_t& version) final {
     return seastar::now();
   }
+
+  bool is_single_chunk(const hobject_t& obj, const ECSubRead& op);
+
+  ll_read_errorator::future<ceph::bufferlist> maybe_chunked_read(
+    const hobject_t& obj,
+    const ECSubRead& op,
+    std::uint64_t off,
+    std::uint64_t size,
+    std::uint32_t flags);
+
+  ceph::ErasureCodeInterfaceRef ec_impl;
+  const ECUtil::stripe_info_t sinfo;
 };
 
 }