From: Peter Dillinger Date: Wed, 7 Jun 2023 20:21:31 +0000 (-0700) Subject: Fix old comment about HyperClockCache and SecondaryCache (#11517) X-Git-Tag: v8.3.2~2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=32c6de7bc31a4d5342d02a22d1a08a658ec3650f;p=rocksdb.git Fix old comment about HyperClockCache and SecondaryCache (#11517) Summary: Support was added in 8.1.0 Pull Request resolved: https://github.com/facebook/rocksdb/pull/11517 Test Plan: comments only Reviewed By: anand1976 Differential Revision: D46489929 Pulled By: pdillinger fbshipit-source-id: 4fd30078389065c9ec225bf55b6773f1641f0646 --- diff --git a/include/rocksdb/cache.h b/include/rocksdb/cache.h index b64ad7014..532e6e4af 100644 --- a/include/rocksdb/cache.h +++ b/include/rocksdb/cache.h @@ -374,7 +374,6 @@ inline std::shared_ptr NewCompressedSecondaryCache( // * Requires an extra tuning parameter: see estimated_entry_charge below. // Similarly, substantially changing the capacity with SetCapacity could // harm efficiency. -// * SecondaryCache is not yet supported. // * Cache priorities are less aggressively enforced, which could cause // cache dilution from long range scans (unless they use fill_cache=false). // * Can be worse for small caches, because if almost all of a cache shard is