From: Radoslaw Zarzynski <rzarzyns@redhat.com>
Date: Wed, 24 Feb 2021 19:40:56 +0000 (+0000)
Subject: crimson/monc: drop misleading comment about Connection::reply.
X-Git-Tag: v17.1.0~2794^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=3573c5d50e4a7b9264a2927004d6b650a3acd2cd;p=ceph.git

crimson/monc: drop misleading comment about Connection::reply.

Before the commit the `crimson::mon:Connection::reply`
was commented as being specific to the ProtocolV1.
However, the code suggests this member participates also
in V2-related paths like `Connection::renew_tickets()`
where `do_auth()` is called from. `do_auth()` generates
`MAuth` which causes a monitor to send `MAuthReply`.
The `Connection::reply` synchronizes sending the auth
request with response handling.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
---

diff --git a/src/crimson/mon/MonClient.cc b/src/crimson/mon/MonClient.cc
index b7a8023ecb4..e90d73348ec 100644
--- a/src/crimson/mon/MonClient.cc
+++ b/src/crimson/mon/MonClient.cc
@@ -95,7 +95,6 @@ private:
 
 private:
   bool closed = false;
-  // v1
   seastar::shared_promise<Ref<MAuthReply>> reply;
   // v2
   using clock_t = seastar::lowres_system_clock;