From: Radoslaw Zarzynski Date: Tue, 22 Jan 2019 16:25:18 +0000 (+0100) Subject: auth: drop sign_bufferlist() from AuthSessionHandler. X-Git-Tag: v14.1.1~157^2~66 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=364ff3bed322fc9fbc83816e583b0ea88c3cc8d8;p=ceph.git auth: drop sign_bufferlist() from AuthSessionHandler. Signed-off-by: Radoslaw Zarzynski --- diff --git a/src/auth/AuthSessionHandler.h b/src/auth/AuthSessionHandler.h index 28f139d45ec8..e0e10c0d78dd 100644 --- a/src/auth/AuthSessionHandler.h +++ b/src/auth/AuthSessionHandler.h @@ -51,9 +51,6 @@ public: virtual int encrypt_message(Message *message) = 0; virtual int decrypt_message(Message *message) = 0; - virtual int sign_bufferlist(bufferlist &in, bufferlist &out) { - return 0; - }; virtual int encrypt_bufferlist(bufferlist &in, bufferlist &out) { return 0; } diff --git a/src/auth/cephx/CephxSessionHandler.cc b/src/auth/cephx/CephxSessionHandler.cc index 6de300dfbfe2..4b0c1cfd0d5b 100644 --- a/src/auth/cephx/CephxSessionHandler.cc +++ b/src/auth/cephx/CephxSessionHandler.cc @@ -181,29 +181,6 @@ int CephxSessionHandler::check_message_signature(Message *m) return 0; } -int CephxSessionHandler::sign_bufferlist(bufferlist &in, bufferlist &out) -{ - char exp_buf[CryptoKey::get_max_outbuf_size(in.length())]; - - try { - const CryptoKey::in_slice_t sin{in.length(), - reinterpret_cast(in.c_str())}; - const CryptoKey::out_slice_t sout{ - sizeof(exp_buf), - reinterpret_cast(&exp_buf)}; - key.encrypt(cct, sin, sout); - } - catch (std::exception &e) { - lderr(cct) << __func__ << " failed to encrypt signature block" << dendl; - return -1; - } - - - out.append(exp_buf, sizeof(exp_buf)); - - return 0; -} - int CephxSessionHandler::encrypt_bufferlist(bufferlist &in, bufferlist &out) { std::string error; try { diff --git a/src/auth/cephx/CephxSessionHandler.h b/src/auth/cephx/CephxSessionHandler.h index ad4b65aafe9d..5f7bfa592787 100644 --- a/src/auth/cephx/CephxSessionHandler.h +++ b/src/auth/cephx/CephxSessionHandler.h @@ -40,7 +40,6 @@ public: int sign_message(Message *m) override; int check_message_signature(Message *m) override ; - int sign_bufferlist(bufferlist &in, bufferlist &out) override; int encrypt_bufferlist(bufferlist &in, bufferlist &out) override; int decrypt_bufferlist(bufferlist &in, bufferlist &out) override;