From: xie xingguo <xie.xingguo@zte.com.cn>
Date: Tue, 7 Jun 2016 02:17:53 +0000 (+0800)
Subject: auth/cephx: return error if we are unable to decode rotate-key
X-Git-Tag: ses5-milestone5~239^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=3655b0012737bb659a22d595b8db5b48e53faa7f;p=ceph.git

auth/cephx: return error if we are unable to decode rotate-key

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
---

diff --git a/src/auth/cephx/CephxClientHandler.cc b/src/auth/cephx/CephxClientHandler.cc
index a314608cc233..fe1f87a8510c 100644
--- a/src/auth/cephx/CephxClientHandler.cc
+++ b/src/auth/cephx/CephxClientHandler.cc
@@ -167,7 +167,7 @@ int CephxClientHandler::handle_response(int ret, bufferlist::iterator& indata)
 	if (decode_decrypt(cct, secrets, secret_key, indata, error)) {
 	  ldout(cct, 0) << "could not set rotating key: decode_decrypt failed. error:"
 	    << error << dendl;
-	  error.clear();
+	  return -EINVAL;
 	} else {
 	  rotating_secrets->set_secrets(secrets);
 	}