From: Adam King Date: Wed, 5 Feb 2025 22:00:06 +0000 (-0500) Subject: mgr/cephadm: fix typo with vrrp_interfaces in keepalive setup X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=36ad7b55be0ee4083cbfac4b0934d114f130de28;p=ceph.git mgr/cephadm: fix typo with vrrp_interfaces in keepalive setup This was intended to be vrrp_interfaces, the variable actually used later in the code. Instead, due to a typo, it was setting a variable that is unused other than in the log line right after it is set. Issue was introduced in https://github.com/ceph/ceph/commit/58ddc4e20f7cead1f2594241450f4beb5230c746 Signed-off-by: Adam King (cherry picked from commit b16fc92155e3f4bbf161610490b579e950584bbf) --- diff --git a/src/pybind/mgr/cephadm/services/ingress.py b/src/pybind/mgr/cephadm/services/ingress.py index a17000cd6327d..e8f8238cbdc02 100644 --- a/src/pybind/mgr/cephadm/services/ingress.py +++ b/src/pybind/mgr/cephadm/services/ingress.py @@ -351,10 +351,10 @@ class IngressService(CephService): else: for subnet, ifaces in self.mgr.cache.networks.get(host, {}).items(): if subnet == spec.vrrp_interface_network: - vrrp_interface = [list(ifaces.keys())[0]] * len(interfaces) + vrrp_interfaces = [list(ifaces.keys())[0]] * len(interfaces) logger.info( f'vrrp will be configured on {host} interface ' - f'{vrrp_interface} (which is in subnet {subnet})' + f'{vrrp_interfaces} (which is in subnet {subnet})' ) break else: