From: John Mulligan Date: Thu, 30 Mar 2023 20:49:27 +0000 (-0400) Subject: python-common: add a dedicated tox env to run mypy X-Git-Tag: v17.2.8~507^2~13 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=372a9e29cc266ebb0fc990a4c6541693eec857fc;p=ceph.git python-common: add a dedicated tox env to run mypy IMO it's not a good practice to overload a tox rule with multiple different test tools. It forces the tools to share the same virtualenvs and makes it impossible to run the tools individually. A separate mypy env also better matches the other tox.ini files in the ceph tree. Since the new 'mypy' env is in the default env list it will continue to get run automatically when no specific envs are selected. Signed-off-by: John Mulligan (cherry picked from commit ff39f87701ba5935902f2a6c67d7ad178bddc5e0) --- diff --git a/src/python-common/tox.ini b/src/python-common/tox.ini index 0699c04765260..2737a87e8207a 100644 --- a/src/python-common/tox.ini +++ b/src/python-common/tox.ini @@ -1,5 +1,5 @@ [tox] -envlist = py3, lint +envlist = py3, mypy, lint skip_missing_interpreters = true [testenv:py3] @@ -11,6 +11,13 @@ commands= pytest {posargs} mypy --config-file=../mypy.ini -p ceph +[testenv:mypy] +deps= + -rrequirements.txt + -c{toxinidir}/../mypy-constrains.txt +commands= + mypy --config-file=../mypy.ini -p ceph + [tool:pytest] norecursedirs = .* _* virtualenv