From: Eric Sandeen Date: Mon, 20 Apr 2009 02:11:32 +0000 (-0500) Subject: xfstests: skip dump tests if dump utils not found X-Git-Tag: v1.1.0~313 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=37521c67189115aa9333fde26eb81bb509d32ad6;p=xfstests-dev.git xfstests: skip dump tests if dump utils not found I was running xfstests on a NAS box which had no xfsdump, and any tests which required xfsdump were failing in not-so-nice ways: + xfsdump not found 038 [failed, exit status 1] - output mismatch (see 038.out.bad) I think using _notrun is a lot better: 038 [not run] xfsdump not found Signed-off-by: Eric Sandeen Reviewed-by: Christoph Hellwig Reviewed-by: Josef 'Jeff' Sipek" Reviewed-by: Felix Blyakher --- diff --git a/common.dump b/common.dump index 6d2f120f..fcc4945a 100644 --- a/common.dump +++ b/common.dump @@ -23,9 +23,9 @@ if [ -n "$DEBUGDUMP" ]; then [ -x $here/xfsinvutil ] && echo "Using xfstests' xfsinvutil for debug" fi -[ "$XFSDUMP_PROG" = "" ] && _fatal "xfsdump not found" -[ "$XFSRESTORE_PROG" = "" ] && _fatal "xfsrestore not found" -[ "$XFSINVUTIL_PROG" = "" ] && _fatal "xfsinvutil not found" +[ "$XFSDUMP_PROG" = "" ] && _notrun "xfsdump not found" +[ "$XFSRESTORE_PROG" = "" ] && _notrun "xfsrestore not found" +[ "$XFSINVUTIL_PROG" = "" ] && _notrun "xfsinvutil not found" # status returned for not run tests NOTRUNSTS=2