From: Christoph Hellwig Date: Tue, 9 Nov 2010 13:53:39 +0000 (+0100) Subject: xfstests: add test for renaming over non-empty directories X-Git-Tag: v1.1.0~113 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=376623749527399ab39d02c6675999541b657fcc;p=xfstests-dev.git xfstests: add test for renaming over non-empty directories Per Posix renames over non-empty directories should fail, but hfsplus used to allow this (and corrupt the filesystem while doing so). Signed-off-by: Christoph Hellwig Reviewed-by: Dave Chinner --- diff --git a/245 b/245 new file mode 100644 index 00000000..9c1cd3aa --- /dev/null +++ b/245 @@ -0,0 +1,65 @@ +#! /bin/bash +# FS QA Test No. 245 +# +# Check that directory renames onto non-empty targets fail +# +# Based on a bug report and testcase from Vlado Plaga +# +#----------------------------------------------------------------------- +# Copyright (c) 2010 Christoph Hellwig. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# +# creator +owner=hch@lst.de + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +# real QA test starts here +_supported_fs generic +_supported_os Linux + +dir=$TEST_DIR/test-mv + +_cleanup() +{ + rm -rf $dir +} + +trap "_cleanup ; exit \$status" 0 1 2 3 15 + + +mkdir $dir + +mkdir $dir/aa +mkdir $dir/ab +touch $dir/aa/1 +mkdir $dir/ab/aa +touch $dir/ab/aa/2 + +mv $dir/ab/aa/ $dir 2>&1 | _filter_test_dir + +status=0 +exit $status diff --git a/245.out b/245.out new file mode 100644 index 00000000..8322aac2 --- /dev/null +++ b/245.out @@ -0,0 +1,2 @@ +QA output created by 245 +mv: cannot move `TEST_DIR/test-mv/ab/aa/' to `TEST_DIR/test-mv/aa': File exists diff --git a/group b/group index d45c266a..1dcf4ee9 100644 --- a/group +++ b/group @@ -358,3 +358,4 @@ deprecated 242 auto quick prealloc 243 auto quick prealloc 244 auto quota quick +245 auto quick dir